I'm running into an issue where colorbox event bindings are firing even when there's no colorbox-enabled element on the page. It looks to me like the js makes improper use of jquery.once()

Patch coming up...

CommentFileSizeAuthor
#7 colorbox_2.12-2365639-7.patch486 bytesnileshlohar
#4 colorbox_2.12-2365639-4.patch658 bytesnileshlohar
#1 2365639.colorbox-2.5.patch389 byteskatbailey
#1 2365639.colorbox-2.7.patch522 byteskatbailey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

katbailey’s picture

katbailey CreditAttribution: katbailey commented
Status: Active » Needs review
FileSize
2365639.colorbox-2.7.patch522 bytes
2365639.colorbox-2.5.patch389 bytes

Status: Needs review » Needs work

The last submitted patch, 1: 2365639.colorbox-2.5.patch, failed testing.

frjo’s picture

frjo CreditAttribution: frjo commented
Status: Needs work » Closed (cannot reproduce)
nileshlohar’s picture

nileshlohar CreditAttribution: nileshlohar commented
FileSize
colorbox_2.12-2365639-4.patch658 bytes

Straight reroll of patch in #1 for 7.x-2.12

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented
Status: Closed (cannot reproduce) » Needs review

N/W for providing proper patch. This patch will not apply.

Status: Needs review » Needs work

The last submitted patch, 4: colorbox_2.12-2365639-4.patch, failed testing.

nileshlohar’s picture

nileshlohar CreditAttribution: nileshlohar commented
FileSize
colorbox_2.12-2365639-7.patch486 bytes

Oops... my bad.
correcting path and reuploading patch.

nileshlohar’s picture

nileshlohar CreditAttribution: nileshlohar commented
Status: Needs work » Needs review
naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented
Status: Needs review » Reviewed & tested by the community

looks good.
//Naveen

  • rsmylski committed 0ef5cc5 on 7.x-2.x 
    Issue #2365639 by nileshlohar: only run colorbox if there are enabled...
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at Cheeky Monkey Media commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.