Meta Issue: #2205673: [META] Remove all @deprecated functions marked "remove before 8.0"

CommentFileSizeAuthor
#28 2361797-28.patch15.64 KBrpayanm
#21 2361797-21.patch15.68 KBrpayanm
#19 2361797-19.patch16.36 KBPalashvijay4O
#12 2361797-12.patch15.85 KBer.pushpinderrana
#8 2361797-8.patch16.5 KBrpayanm
#6 2361797-6.patch16.47 KBrpayanm
#4 2361843-4.patch16.68 KBrpayanm
#2 2361789-2.patch16.44 KBrpayanm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm commented
Title: Remove drupal_strlen() » Remove usage of drupal_strlen()
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm commented
Status: Active » Needs review
FileSize
2361789-2.patch16.44 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2361789-2.patch, failed testing.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm commented
Status: Needs work » Needs review
FileSize
2361843-4.patch16.68 KB

Status: Needs review » Needs work

The last submitted patch, 4: 2361843-4.patch, failed testing.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm commented
Status: Needs work » Needs review
FileSize
2361797-6.patch16.47 KB

Status: Needs review » Needs work

The last submitted patch, 6: 2361797-6.patch, failed testing.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm commented
Status: Needs work » Needs review
FileSize
2361797-8.patch16.5 KB
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm commented
Assigned: rpayanm » Unassigned

Palashvijay4 queued 8: 2361797-8.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 8: 2361797-8.patch, failed testing.

er.pushpinderrana’s picture

er.pushpinderrana CreditAttribution: er.pushpinderrana commented
Status: Needs work » Needs review
FileSize
2361797-12.patch15.85 KB

Re-rolled #8 Patch

Palashvijay4O’s picture

Palashvijay4O CreditAttribution: Palashvijay4O commented

Great !! Applied successfully !!

Palashvijay4O’s picture

Palashvijay4O CreditAttribution: Palashvijay4O commented

@er.pushpinderrana I think declaration of drupal_strlen() in core/includes/unicode.inc and also the documentation related to that should be removed . 

 function drupal_strlen($text) {
  return Unicode::strlen($text);
}
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm commented

@Palashvijay4 The function would be remove in #2361799: Remove drupal_strlen., here only the usage.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented
Status: Needs review » Reviewed & tested by the community

No occurrences left and Patch looks ok to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Needs a reroll

git ac https://www.drupal.org/files/issues/2361797-12.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 16226  100 16226    0     0  46381      0 --:--:-- --:--:-- --:--:-- 50391
error: patch failed: core/lib/Drupal/Core/Mail/MailFormatHelper.php:8
error: core/lib/Drupal/Core/Mail/MailFormatHelper.php: patch does not apply
error: patch failed: core/modules/text/text.module:6
error: core/modules/text/text.module: patch does not apply
Palashvijay4O’s picture

Palashvijay4O CreditAttribution: Palashvijay4O commented
Assigned: Unassigned » Palashvijay4O
Palashvijay4O’s picture

Palashvijay4O CreditAttribution: Palashvijay4O commented
Status: Needs work » Needs review
FileSize
2361797-19.patch16.36 KB

re-roll .

Status: Needs review » Needs work

The last submitted patch, 19: 2361797-19.patch, failed testing.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
2361797-21.patch15.68 KB

Palashvijay4O queued 19: 2361797-19.patch for re-testing.

The last submitted patch, 19: 2361797-19.patch, failed testing.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm commented

@Palashvijay4O you patch not apply because you're working in an obsolete code, you have to do a "git pull", and then update your patch.

Palashvijay4O’s picture

Palashvijay4O CreditAttribution: Palashvijay4O commented

@rpayanm thanks ... i realized that later ...

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm commented
Status: Needs review » Reviewed & tested by the community

Reroled, then RTBC...

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 21: 2361797-21.patch, failed testing.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm commented
Status: Needs work » Reviewed & tested by the community
FileSize
2361797-28.patch15.64 KB

rerolling...

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

This issue is a prioritized change as per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase? and it's benefits outweigh any disruption. Committed 12ba160 and pushed to 8.0.x. Thanks!

  • alexpott committed 12ba160 on 8.0.x 
    Issue #2361797 by rpayanm, Palashvijay4O, er.pushpinderrana: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.