Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I think we all agree that the "Hosting Features" subsystem is... not ideal.
What if we leverage drupal's module system properly? What if we use the amazing Module Filter module?
I have an idea, which I've implemented on a new branch.
- Include module_filter module in hostmaster.
- Load in the system modules form at admin/hosting.
- Form Alter the system modules form at admin/hosting by removing all non-hosting modules. (for now I'm using hosting_get_features()) to determine what modules are "hosting" modules. )
- Use module "package" to instead of hosting_features "group" to keep things together.
Thoughts?
Comment | File | Size | Author |
---|---|---|---|
#1 | Screenshot from 2014-10-19 12:45:59.png | 122.89 KB | Jon Pugh |
Comments
Comment #1
Jon PughUploading a screenshot. It's a start.
We should remove sidebar blocks in admin pages, too.
Comment #3
helmo CreditAttribution: helmo commentedGreat, works in my quick test.
Comment #4
omega8cc CreditAttribution: omega8cc commentedI don't like this idea. It is confusing. Previously it was easy to see Hostmaster specific features/modules with extra section for experimental features. Just like Features are separated from Modules, because they are functionally Features (bundles) and not just Modules. Now it will be a standard Drupal mess. Please don't do this.
Comment #5
Jon PughRe: helmo:
Re: omega8cc: I think we can address those concerns. I already planned on updating "Package" to reflect the hosting feature "group" parameter.
What would you say is confusing about it, other than the lack of separation of "experimental" modules?
We can do more here to make this less confusing, for sure. Perhaps removing the requirements would reduce clutter?
Comment #6
ergonlogicAs long as we don't lose functionality, I'd support this. It's a lot of code we shouldn't really need to maintain. I believe that we can add arbitrary data into a module's .info, no? in that case, maybe we can put the Hosting Features meta-data there.
Comment #7
omega8cc CreditAttribution: omega8cc commentedI vote no if it will make the current elegant listing ugly - which is typical for Drupal own module listing.
If it will look at least similarly to what we have now, then OK. Not sure if related code we need to "maintain" currently really needs any maintenance?
But if it will replace the current minimal and elegant listing of Aegir specific features with cluttered visually Drupal chaos in the module listing, then what is the purpose/reasoning behind this change, if I can see basically the same in the Drupal own module listing with some filtering there?
Please don't make it ugly w/o any other good reason than a temptation to remove some code we need to "maintain".
Comment #8
helmo CreditAttribution: helmo commentedMore work to be done ... after enabling a module via this patch other modules like admin_menu become disabled.
To make a better case for code we can remove it would be nice to remove it with the patch.
Comment #9
helmo CreditAttribution: helmo at Initfour websolutions commentedI've included the module_filter module in hostmaster as a tiny step forward.
Comment #11
colanJust finding this now...
#7: To maintain the Experimental/Advanced/etc. functionality, why don't we just make those the package names in Drupal core's system?
To go a bit further (probably too much): We could just use core only, and remove all of the Hosting Features stuff entirely (and then of course change all of the module package names to those listed above).