Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#38 | 2358999-38.patch | 8.8 KB | rpayanm |
#38 | 2358999-interdiff.txt | 1.69 KB | rpayanm |
Comments
Comment #1
aczietlow CreditAttribution: aczietlow commentedI used the folowing to find all usages of drupal_html_to_text excluding any usages in a vendor directory.
> git grep --after-context 8 '@deprecated' | grep "drupal_html_to_text" | grep -v 'core/vendor' | rev | cut -c 2- | rev
The depreciated function will still need to be removed in another patch.
Comment #2
JeroenTCreated issue to remove the function drupal_html_to_text: #2359069: Remove drupal_html_to_text()..
Comment #3
Ec1ipsis CreditAttribution: Ec1ipsis commentedUpdated patch file to fix some commenting code style issues.
Comment #5
rpayanmrerolling...
Comment #6
quietone CreditAttribution: quietone commentedWorks for me.
Grep doesn't return any "drupal_html_to_text" instances and tests on the changed modules pass.
Comment #7
javivf CreditAttribution: javivf commentedI do a reroll to apply patch
Comment #10
rpayanmComment #11
aczietlow CreditAttribution: aczietlow commented@javivf It's unclear to me what this reroll (#7) was for? Should we be removing form_set_cache() or replacing decode_entities() for this?
Comment #12
rpayanm@aczietlow yes It's a strange patch :( let me make a reroll.
Comment #13
quietone CreditAttribution: quietone commentedPatch from #12 works for me.
Grep doesn't return any "drupal_html_to_text" instances, tests passed.
Comment #14
aczietlow CreditAttribution: aczietlow commentedConfirming that #12 passes all tests and has no usages of drupal_html_to_text().
Comment #15
rpayanmThen RTBC :D
Comment #16
herom CreditAttribution: herom commentedWe shouldn't change drupal_wrap_mail() here.
Comment #17
rpayanm@herom thank you, nice catch!
fixed!
Comment #18
JeroenTPatch looks RTBC!
Comment #19
JeroenTComment #21
JeroenTComment #22
er.pushpinderrana CreditAttribution: er.pushpinderrana commentedComment #23
rpayanmComments must be <= 80 characters per line.
Comment #24
JeroenTMade some changes as suggested by rpayanm in #23. Patch attached.
Comment #25
rpayanmIt's nice for me.
Comment #26
alexpottComment #27
rpayanmrerolling...
Comment #28
rpayanmComment #29
aspilicious CreditAttribution: aspilicious commentedComment #30
alexpottPlease add this issue to the relevant CR
Comment #31
JeroenTComment #32
alexpottOne of the deprecated function removal has caused this to need a reroll. The drupal_strtolower() - make sure when reroll to not reintroduce a usage of that function.
Comment #33
rpayanmComment #34
aspilicious CreditAttribution: aspilicious commentedComment #35
rpayanmReferenced this issue on the following change record: [#1992584].
Comment #36
quietone CreditAttribution: quietone commentedLooks good to me. grep only finds the functions drupal_strtolower and drupal_html_to_text.
Though I think the modified change record is actually https://www.drupal.org/node/2309379
Comment #37
alexpottAll too long. The coding standard is that the first line of a method doc block should fit on one line.
Here is a suggestion.
Comment #38
rpayanm@alexpott thank you, then here the patch.
Comment #39
rpayanmMinor changes so RTBC...
Comment #40
alexpottThis issue is a prioritized change as per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase? and it's benefits outweigh any disruption. Committed 5528695 and pushed to 8.0.x. Thanks!