Remove messages icons in misc

Icons for messages are removed from misc. I doubled checked them all they are not in usage.

Tested and old massage icons are not there anymore.

Can't figure it out why it didn't pass the test.

Also checked few pages for usability of this icons and they are switched with new SVG icons from the /core/misc/icons folder.

Well I get the same fails locally so we can't commit this patch until someone does work out why.

function filter_filter_secure_image_alter(&$image) {
  // Turn an invalid image into an error indicator.
  $image->setAttribute('src', base_path() . 'core/misc/message-16-error.png');
  $image->setAttribute('alt', t('Image removed.'));
  $image->setAttribute('title', t('This image has been removed. For security reasons, only images from the local domain are allowed.'));
  $image_factory = \Drupal::service('image.factory');
  $error_image = $image_factory->get('core/misc/message-16-error.png');
  $image->setAttribute('height', $error_image->getHeight());
  $image->setAttribute('width',  $error_image->getWidth());

  // Add a CSS class to aid in styling.
  $class = ($image->getAttribute('class') ? trim($image->getAttribute('class')) . ' ' : '');
  $class .= 'filter-image-invalid';
  $image->setAttribute('class', $class);
}

Almost certainly this code is why.

grepping the codebase for message.*png should return no results - we need to update 4 instances to the new svg path.

HTML width and height attributes expect a numeric value, so we don't need the px. This should let the tests succeed too.

This issue is a normal task so we need to outline how it fits within the allowable Drupal 8 beta criteria. Can someone add Drupal 8 beta phase evaluation template to the issue summary.
Action: Needs work, Needs issue summary update

Good point @LewisNyman yep a CR for the parent issue - and connect it all the child issues.

I have read the change record and it describes the changes well and links to the Meta issue. Setting this to RTBC.

+++ b/core/modules/filter/filter.module
@@ -831,13 +831,13 @@ function _filter_html_image_secure_process($text) {
   $image_factory = \Drupal::service('image.factory');
-  $error_image = $image_factory->get('core/misc/message-16-error.png');
-  $image->setAttribute('height', $error_image->getHeight());
-  $image->setAttribute('width',  $error_image->getWidth());
+  $error_image = $image_factory->get('core/misc/icons/ea2800/error.svg');
+  $image->setAttribute('height', '16');
+  $image->setAttribute('width',  '16');
 

We can avoid entirely going through the image factory in this case. No need for $image_factory and $error_image variables.

Actually, the underlying toolkit (GD) will not be able to load an SVG image here (it can be checked by calling $error_image->isValid() that will just return FALSE).

Looks good to me. I'm happy to mark this RTBC.

Here's a copy of an error message:

The patch in #17 has never been tested - not sure why - reuploading - no commit credit for me, thanks.

Committed aec0d2b and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation for to the issue summary.