Follow-up to SA-CORE-2014-005.

The test introduced INSERT INTO SET, which is mysql only. Patch will follow.

CommentFileSizeAuthor
#12 2357311-d7.patch633 bytespenyaskito
#2 2357311-d8.patch645 bytespenyaskito
#1 2357311-d7.patch633 bytespenyaskito
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Active » Needs review
FileSize
2357311-d7.patch633 bytes

D7 patch....

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
FileSize
2357311-d8.patch645 bytes

D8 patch.

Status: Needs review » Needs work

The last submitted patch, 2: 2357311-d8.patch, failed testing.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Title: Follow-up to SA-CORE-2014-005 » Follow-up to SA-CORE-2014-005 (tests don't work correctly on non-MySQL databases)
Version: 7.x-dev » 8.0.x-dev
Status: Needs work » Needs review
Issue tags: +Needs backport to D7

Oops, nice find. Patches look good... setting this to D8 for the testbot to run on it there.

David_Rothstein queued 2: 2357311-d8.patch for re-testing.

Crell’s picture

Crell CreditAttribution: Crell commented
Status: Needs review » Reviewed & tested by the community

Ugh. Postgres. :-)

Thanks, penyaskito.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Version: 8.0.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed 88dcf91 and pushed to 8.0.x. Thanks!

  • alexpott committed 88dcf91 on 8.0.x 
    Issue #2357311 by penyaskito: Fixed Follow-up to SA-CORE-2014-005 (tests...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Patch (to be ported) » Needs review

#1 works for D7.

Crell’s picture

Crell CreditAttribution: Crell commented
Status: Needs review » Reviewed & tested by the community

Same patch, same status.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2357311-d8.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Needs work » Reviewed & tested by the community
FileSize
2357311-d7.patch633 bytes

Reuploading, looks like the bot takes the last one.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

  • David_Rothstein committed 0b4c3b1 on 7.x 
    Issue #2357311 by penyaskito: Fixed Follow-up to SA-CORE-2014-005 (tests...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue tags: -Needs backport to D7