Editing a grouped filter (eg. Content publishing status on admin/structure/views/view/content) shows that the tabledrag grippie and operations are double escaped rendering them unusable.

CommentFileSizeAuthor
#4 2356297-4.patch3.17 KBolli
#4 2356297-test.patch1.13 KBolli
#1 2356297.1.patch2.05 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Active » Needs review
FileSize
2356297.1.patch2.05 KB

One possible fix.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: +Needs tests

Nice, but we need some tests here.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: +Needs tests

Nice, but we need some tests here.

olli’s picture

olli CreditAttribution: olli commented
FileSize
2356297-test.patch1.13 KB
2356297-4.patch3.17 KB

Here's a test.

The last submitted patch, 4: 2356297-test.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs review » Reviewed & tested by the community

Test-only patch falis, fix+test patch passes.
RTBC ?

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

I agree that this issue is a major bug, so it is allowed per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?. Committed to 8.0.x-dev.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs work » Fixed
mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
CreditAttribution: mallezie commented
Status: Fixed » Needs work

d.o strangeness

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Needs work » Reviewed & tested by the community

re #10 there is no d.o strangeness - the patch has not been pushed - I guess #1089672: Fatal error while perfoming git push to drupal.org Git repositories occurred. The correct status is probably rtbc.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed it now. Sorry, yesterday wasn't my day.

  • Dries committed f66616b on 8.0.x 
    Issue #2356297 by olli, alexpott: Fixed Double escaping in views ui...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Issue tags: +SafeMarkup

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.