Problem/Motivation

We need an upgrade path from D7 for the core Update module.

Proposed Resolution

Update doesn't maintain any data that needs to be migrated. Its variables only need to be moved into configuration.

Remaining Tasks

  1. Update the patch to match HEAD
  2. Write tests
  3. Review the patch
  4. Commit!
CommentFileSizeAuthor
#21 2353813-21.patch3.25 KBquietone
#19 interdiff-2353813-15-19.txt2.97 KBphenaproxima
#19 2353813-19.patch2.58 KBphenaproxima
#15 migration_path-2353813-15.patch3.49 KBtalhaparacha
#9 2353813-9.patch3.49 KBphenaproxima
#7 2353813-7.patch3.48 KBphenaproxima
#6 2353813-6.patch3.46 KBphenaproxima
#5 2353813-5.patch3.75 KBphenaproxima
#1 update_settigns-2353813-1.patch951 byteshosef
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hosef’s picture

hosef CreditAttribution: hosef commented
Status: Active » Needs work
FileSize
update_settigns-2353813-1.patch951 bytes

Attached is the YAML for this issue, from the patch in #2382117: Migration Files for Drupal 7 Variables.
Test(s) (and maybe a dump file) still need to be written.

miguelc303’s picture

miguelc303 CreditAttribution: miguelc303 at Anexus commented

Added organization support to Anexus IT

jcost’s picture

jcost CreditAttribution: jcost commented
Project: IMP » Drupal core
Version: » 8.0.x-dev
Component: Code » migration system

Will need to be submitted again to Core since moving from sandbox.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Title: Variable to config: update.settings [d7] » Upgrade path for Update 7.x
Priority: Normal » Minor
Issue summary: View changes
Parent issue: #2181257: [meta] Variables to config migration [d7] » #2456259: [META] Drupal 7 to Drupal 8 Migration path
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Needs review
FileSize
2353813-5.patch3.75 KB

Updated, and wrote a test.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
FileSize
2353813-6.patch3.46 KB

Re-roll.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
FileSize
2353813-7.patch3.48 KB

Re-rolled in accordance with #2533886: [meta] Move module-specific migration support into the particular modules supported.

Status: Needs review » Needs work

The last submitted patch, 7: 2353813-7.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Needs review
FileSize
2353813-9.patch3.49 KB

Messed up a namespace. Let's try that again.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community

Looks good.

The last submitted patch, 1: update_settigns-2353813-1.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Title: Upgrade path for Update 7.x » Migration path for Update 7.x
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll 
git ac https://www.drupal.org/files/issues/2353813-9.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3576  100  3576    0     0   4780      0 --:--:-- --:--:-- --:--:-- 12416
error: patch failed: core/modules/migrate_drupal/src/Tests/Table/d7/Variable.php:440
error: core/modules/migrate_drupal/src/Tests/Table/d7/Variable.php: patch does not apply
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Postponed

Because Variable.php causes re-rolls every single time a variable-to-config migration is committed (due to the ham-fisted hashing strategy employed by migrate-db.sh), I have decided to postpone re-rolling this until #2409441: Migration path for Text 7.x lands.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Postponed » Needs review

Unblocked!

talhaparacha’s picture

talhaparacha CreditAttribution: talhaparacha as a volunteer commented
Issue tags: -Needs reroll
FileSize
migration_path-2353813-15.patch3.49 KB

Re-roll. This patch applies cleanly at commit 15b2b5edc.

Status: Needs review » Needs work

The last submitted patch, 15: migration_path-2353813-15.patch, failed testing.

Status: Needs work » Needs review

talhaparacha queued 15: migration_path-2353813-15.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 15: migration_path-2353813-15.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Needs review
FileSize
2353813-19.patch2.58 KB
interdiff-2353813-15-19.txt2.97 KB

I noticed that d7_update_settings was identical to d6_update_settings, so I merged them.

Status: Needs review » Needs work

The last submitted patch, 19: 2353813-19.patch, failed testing.

quietone’s picture

quietone CreditAttribution: quietone commented
FileSize
2353813-21.patch3.25 KB

Reroll

quietone’s picture

quietone CreditAttribution: quietone commented
Status: Needs work » Needs review
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Acquia commented
Status: Needs review » Reviewed & tested by the community

Looks good!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed d3f6df8 on 8.1.x 
    Issue #2353813 by phenaproxima, quietone, talhaparacha, hosef: Migration...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.