Custom registration fields should appear on admin/user/create [#23536]

Comment	File	Size	Author
#6	user_reg_1.patch	8 KB	chx

#5	user_reg_4.6.2.patch	8.33 KB	Torenware

#4	user_reg_0.patch	9.01 KB	chx

#1	user_reg.patch	8.69 KB	chx

Comment #1

chx CreditAttribution: chx commented 25 June 2005 at 22:27

Component:	profile.module	» user.module
Assigned:	Unassigned	» chx

File	Size
user_reg.patch	8.69 KB

At first I thought it'd be better if I'd keep the separate form, but this version results in shorter code and it's not so ugly. However, if you do not like it, I have the version which only adds the $extra to user_admin_create.

Log in or register to post comments

Comment #2

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 26 June 2005 at 18:08

I like this patch.

Log in or register to post comments

Comment #3

moshe weitzman CreditAttribution: moshe weitzman commented 28 June 2005 at 01:53

to me, this version is great as it unifies the registration code. i did a code review and all looks good to me. i applied the patch and noticed that

- i added a required checkbox field via profile.module. the check appeared on the reg form without the 'required' marker and the registration was accepted without checking the box. then i tried this for a textfield and it properly showed the 'required' marker but it didn't enforce the 'required' bit either. so then i tried to edit the user and even then we seem not to be enforcing the 'required' bit. this looks like a profile.module bug.

if you are up for it, you might want to investigate the above. but truly, enforcing the required bit is not related to this patch. so +1 from me.

Log in or register to post comments

Comment #4

chx CreditAttribution: chx commented 1 July 2005 at 06:00

File	Size
user_reg_0.patch	9.01 KB

It was intentional that the check for required fields are skipped for admins. I deleted that check.

Log in or register to post comments

Comment #5

Torenware CreditAttribution: Torenware commented 6 July 2005 at 06:28

File	Size
user_reg_4.6.2.patch	8.33 KB

This patch is massively useful (at least for me...) and was exactly what I was looking for.

Since I can't use the CVS version, I back-ported it to 4.6.2. It's syntactically valid, and it seems to work, although I have not tested it thoroughly. I'm uploading it in case anyone else wants to try it out, or is willing to test it. I'll be using it in any case.

YMMV, of course :-)

Rob Thorne
Torenware Networks