Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Meta issue: #2205673: [meta] Remove all @deprecated functions marked "remove before 8.0"
Problem/Motivation
taxonomy_term_load_parents_all() is deprecated.
Proposed resolution
Remove it.
Remaining tasks
N/A
User interface changes
N/A
API changes
taxonomy_term_load_parents_all() is finally gone.
Link to change records
Comment | File | Size | Author |
---|---|---|---|
#10 | interdiff.txt | 511 bytes | bertramakers |
#10 | 2353013-10.patch | 1.52 KB | bertramakers |
Comments
Comment #1
crazyrohila CreditAttribution: crazyrohila commentedRemoved taxonomy_term_load_parents_all() from taxnomy.module
Comment #2
oenie CreditAttribution: oenie commentedI've removed some extra @todo comment and changed the documentation in the interface.
Comment #3
ashutoshsngh CreditAttribution: ashutoshsngh commentedApplied patch and checked.It works well changing to RTBC.
Comment #4
alexpottCan someone attach this issue to the correct CR that announced the replacement of taxonomy_term_load_parents_all
Comment #5
a_thakur CreditAttribution: a_thakur commentedComment #6
a_thakur CreditAttribution: a_thakur commentedAdded link to the the change record: https://www.drupal.org/node/2328205. Changing to RTBC.
Comment #7
alexpottThis documentation now seems out of sync - but it was just wrong before too since it is a public method on an interface. I think we should still be saying that this is just a wrapper.
This @todo should still in exist but in changed from FormManagerInterface::getParents() was just a wrapper to TermStorage::loadAllParents(). We should remove FormManagerInterface::getParents() in 9.x This patch should be adding the deprecated notice to this function and creating the postponed 9.x issue to remove it.
Comment #8
bertramakers CreditAttribution: bertramakers commentedI'm sprinting at DrupalCamp Ghent and we're looking into this issue.
I'll create the issue to remove the getParents() method from the ForumManagerInterface in 9.x, and create a patch with an interdiff for the todo comment.
Comment #9
bertramakers CreditAttribution: bertramakers commentedI just created #2371593: Properly deprecate ForumManagerInterface::getParents()..
Comment #10
bertramakers CreditAttribution: bertramakers commentedComment #11
LOBsTerr CreditAttribution: LOBsTerr commentedApplied the patch and checked the patch. Everything is ok for me.
Comment #12
pfrenssenThis looks ready. Thanks!
Comment #13
pfrenssenComment #14
alexpottThis issue is a prioritized change (deprecated function removal) as per https://www.drupal.org/core/beta-changes and it's benefits outweigh any disruption. Committed 0f438fa and pushed to 8.0.x. Thanks!