Meta issue: #2205673: [meta] Remove all @deprecated functions marked "remove before 8.0"

Problem/Motivation

taxonomy_term_load_parents_all() is deprecated.

Proposed resolution

Remove it.

Remaining tasks

N/A

User interface changes

N/A

API changes

taxonomy_term_load_parents_all() is finally gone.

Link to change records

https://www.drupal.org/node/2328205

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

crazyrohila’s picture

Status: Active » Needs review
FileSize
676 bytes

Removed taxonomy_term_load_parents_all() from taxnomy.module

oenie’s picture

I've removed some extra @todo comment and changed the documentation in the interface.

ashutoshsngh’s picture

Status: Needs review » Reviewed & tested by the community

Applied patch and checked.It works well changing to RTBC.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Can someone attach this issue to the correct CR that announced the replacement of taxonomy_term_load_parents_all

a_thakur’s picture

Issue summary: View changes
a_thakur’s picture

Status: Needs work » Reviewed & tested by the community

Added link to the the change record: https://www.drupal.org/node/2328205. Changing to RTBC.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
  1. +++ b/core/modules/forum/src/ForumManagerInterface.php
    @@ -57,16 +57,13 @@ public function getIndex();
    +   * Fetches the parent forums for a given forum.
        *
        * @param int $tid
        *   Term ID.
        *
        * @return array
        *   Array of parent terms.
    

    This documentation now seems out of sync - but it was just wrong before too since it is a public method on an interface. I think we should still be saying that this is just a wrapper.

  2. +++ b/core/modules/forum/src/ForumManagerInterface.php
    @@ -57,16 +57,13 @@ public function getIndex();
    -   * @todo remove and inject a service when taxonomy_term_get_parents_all has an
    -   *   object-oriented equivalent.
    

    This @todo should still in exist but in changed from FormManagerInterface::getParents() was just a wrapper to TermStorage::loadAllParents(). We should remove FormManagerInterface::getParents() in 9.x This patch should be adding the deprecated notice to this function and creating the postponed 9.x issue to remove it.

bertramakers’s picture

I'm sprinting at DrupalCamp Ghent and we're looking into this issue.
I'll create the issue to remove the getParents() method from the ForumManagerInterface in 9.x, and create a patch with an interdiff for the todo comment.

bertramakers’s picture

bertramakers’s picture

Status: Needs work » Needs review
FileSize
1.52 KB
511 bytes
LOBsTerr’s picture

Applied the patch and checked the patch. Everything is ok for me.

pfrenssen’s picture

Status: Needs review » Reviewed & tested by the community

This looks ready. Thanks!

pfrenssen’s picture

Issue tags: +DrupalCamp Ghent 2014
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

This issue is a prioritized change (deprecated function removal) as per https://www.drupal.org/core/beta-changes and it's benefits outweigh any disruption. Committed 0f438fa and pushed to 8.0.x. Thanks!

  • alexpott committed 0f438fa on 8.0.x
    Issue #2353013 by bertramakers, oenie, crazyrohila: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.