Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Problem/Motivation
if (!$language->isLocked() && $language->getWeight() > $max_weight) {
$max_weight = $language->getWeight();
}
Proposed resolution
Use max()
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#8 | 2350941-interdiff-7.txt | 694 bytes | rpayanm |
#8 | 2350941-8.patch | 1.55 KB | rpayanm |
#6 | 2350941-6.patch | 1.79 KB | rpayanm |
#3 | 2350941-3.patch | 738 bytes | rpayanm |
Comments
Comment #1
dawehnerComing from #2304403: Convert language:weight into a protected property
Comment #2
dawehner.
Comment #3
rpayanmWorking on this...
Comment #4
YesCT CreditAttribution: YesCT commentedThanks. That looks good.
was there something else you wanted to work on? unassigning since it was green and want to be able to continue to move this issue forward. comment here or ping me irc if you were in the middle of something.
Comment #5
YesCT CreditAttribution: YesCT commentedI'm not sure how many places we want to look for patterns like that, but I think we can do both that were in #2304403: Convert language:weight into a protected property.
There is another in ConfigurableLanguageManager.
Comment #6
rpayanmfixed :D
Comment #7
YesCT CreditAttribution: YesCT commentedthanks.
--
I took a look at the patch.
out of scope for this issue.
--
the rest looks ok.
--
Note https://drupal.org/documentation/git/interdiff is really nice when working on an issue that has a previous patch. It really helps reviewers.
Comment #8
rpayanmsorry, here the patch and interdiff for you last correction :)
Comment #9
YesCT CreditAttribution: YesCT commentedthis looks super. improves just the two from the other patch that @dawehner spotted.
Comment #10
alexpottCommitted 8b24674 and pushed to 8.0.x. Thanks!