Problem/Motivation

The CKEditor configuration UI allows tabs to be used in toolbar group names, which is fine, but they also end up in the group's element id.
The id is only used in the configuration UI so it does not create any problems during normal use of the editor.
(Unless maybe the tab makes a difference for screen readers when moving between button groups.)

Proposed resolution

Properly replace all whitespaces using the RegExp /\s/g instead of the current use of / /g.

Remaining tasks

None

User interface changes

No visible changes.

API changes

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TwoD’s picture

Status: Active » Needs review
FileSize
817 bytes

And here's the patch. :)

Status: Needs review » Needs work

The last submitted patch, 1: d8-ckeditor-ui-whitespaces.2350065.1.patch.patch, failed testing.

TwoD’s picture

Status: Needs work » Needs review
Issue tags: +drupalcon code sprint

The poor testbot wasn't prepared for DrupalCon. :(

Wim Leers’s picture

Title: Tabs in element ids for CKEditor config UI » \t in element IDs for CKEditor config UI
Status: Needs review » Reviewed & tested by the community
Issue tags: +Amsterdam 2014

Great, thanks! :)

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed c752a36 and pushed to 8.0.x. Thanks!

  • alexpott committed c752a36 on 8.0.x
    Issue #2350065 by TwoD: Fixed \t in element IDs for CKEditor config UI.
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

YesCT’s picture

Issue tags: -Amsterdam 2014 +Amsterdam2014

fixing the tag, so I can delete the least used one.