Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
The menu button (hamburger) is overlapping on Menu text when using RTL mode on mobile.
Proposed resolution
The button could be moved to the left side of the screen.
User interface changes
Menu text on RTL and mobile will be moved to the left side of the screen.
Remaining tasks
Write patch
Manual testing
API changes
n/o
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | hamburguer-menu-after.png | 26.58 KB | rteijeiro |
| #11 | hamburguer-menu-before.png | 27.19 KB | rteijeiro |
| #2 | fix-menu-button-position-in-rtl.patch | 609 bytes | skippednote |
| #2 | fix-menu-button-position-fixed.png | 57.99 KB | skippednote |
| fix-menu-button-position.png | 67.17 KB | skippednote | |
Comments
Comment #1
rvilarI'm working on that
Comment #2
skippednote CreditAttribution: skippednote commentedMoved the menu button to left and it isn't overlapping anymore.
Comment #3
skippednote CreditAttribution: skippednote commentedComment #4
Tomefa CreditAttribution: Tomefa commentedChanged the issue title, what we have to do is to hide the primay menu label on a mobile screen size.
And keep the menu icon on the right.
Comment #5
skippednote CreditAttribution: skippednote commentedAre we sure we want to remove the Menu text? It's there in LTR and has been themed to be a part of the menu.
Comment #6
LewisNymanUpdated the title to reflect the problem
Comment #7
skippednote CreditAttribution: skippednote commentedmoving to "Needs Review" now that the requirements are clear.
Comment #8
lauriiiComment #9
Tomefa CreditAttribution: Tomefa commentedOk right, the menu label need to be display.
But because we are on a RTL language the menu label is better on the left and the hamburger on the right.
Like the admin menu.
What do you think ?
Comment #10
stefika CreditAttribution: stefika commentedRemoving unnecessary comment.
Comment #11
rteijeiro CreditAttribution: rteijeiro commentedIt looks good for me. Let's go for RTBC
BEFORE
AFTER
Comment #12
alexpottThis issue is a normal bug fix, and and is an unfrozen change, so it is allowed per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?. Committed 2ba5141 and pushed to 8.0.x. Thanks!