drupal_bootstrap and drupal_get_bootstrap_phase are deprecated and should be removed.

CommentFileSizeAuthor
#26 14-25-interdiff.txt804 bytesalexpott
#26 2347625-2.25.patch6.74 KBalexpott
#14 2347625-14.patch5.95 KBidebr
#3 2347625.3.patch6.15 KBalexpott
#3 1-3-interdiff.txt3.1 KBalexpott
#1 2347625.1.patch3.36 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Active » Needs review
FileSize
2347625.1.patch3.36 KB

Status: Needs review » Needs work

The last submitted patch, 1: 2347625.1.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Needs work » Needs review
FileSize
1-3-interdiff.txt3.1 KB
2347625.3.patch6.15 KB

We can remove the constants too.

Opened https://github.com/drush-ops/drush/pull/857 to fix drush - @moshe is working on a better way.

Status: Needs review » Needs work

The last submitted patch, 3: 2347625.3.patch, failed testing.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo commented
Related issues: +#2205673: [META] Remove all @deprecated functions marked "remove before 8.0"
rickvug’s picture

rickvug CreditAttribution: rickvug commented

The GitHub issue has sat for over a month now. I guess it is time to get the pull request merged in as-is so that this issue can move forward.

Status: Needs work » Needs review

rpayanm queued 3: 2347625.3.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 3: 2347625.3.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

Next step is to get drush upgraded on the testbots

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm commented
Parent issue: » #2373319: Update drush

Here the issue #2373319: Update drush.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm commented
Parent issue: #2373319: Update drush »

upss already referenced...

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented
Status: Needs work » Postponed

This is postponed on #2404923: Upgrade Drush on qa.d.o.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Postponed » Active

#2404923: Upgrade Drush on qa.d.o was fixed yesterday.

idebr’s picture

idebr CreditAttribution: idebr commented
Status: Active » Needs review
FileSize
2347625-14.patch5.95 KB

Straight reroll of #3

Status: Needs review » Needs work

The last submitted patch, 14: 2347625-14.patch, failed testing.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo commented

Test fails because drush generates the following error upon enabling the simpletest module.

Notice: Use of undefined constant DRUPAL_BOOTSTRAP_CONFIGURATION - assumed 'DRUPAL_BOOTSTRAP_CONFIGURATION' in drupal8_bootstrap() (line 824 of /usr/local/bin/drush-master/lib/Drush/Boot/bootstrap.inc).

I am able to reproduce this error locally with a clean install on a VDD (Vagrant Drupal Development) machine.
Drupal installs perfectly using drush @drupal8 si standard, however drush @drupal8 si simpletest fails with the error mentioned above.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented

I created an issue on github to remove the usage of this constants in drush: https://github.com/drush-ops/drush/issues/1183

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

This should work now that testbots no longer use drush.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented

This is the error:
'Failed to drush en simpletest, output=<em class="placeholder">Notice</em>: Use of undefined constant DRUPAL_BOOTSTRAP_CONFIGURATION - assumed \'DRUPAL_BOOTSTRAP_CONFIGURATION\' in <em class="placeholder">drupal8_bootstrap()</em> (line <em class="placeholder">828</em> of <em class="placeholder">/opt/drush/lib/Drush/Boot/bootstrap.inc</em>).PHP Fatal error: Allowed memory size of 335544320 bytes exhausted (tried to allocate 101 bytes) in /opt/drush/includes/environment.inc on line 42

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

The dependency on drush was removed on Monday evening.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo commented
Issue tags: +Needs reroll

Tests failing because patch can't be applied.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
2347625-2.25.patch6.74 KB
14-25-interdiff.txt804 bytes

Rerolled and removed a weirdly pointless comment the references drupal_bootstrap

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

Also RIP.

  • catch committed 7670ea4 on 8.0.x 
    Issue #2347625 by alexpott, idebr: Remove drupal_bootstrap and...
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

Ouch, this killed drush in a bad way. Please help me fix it in https://github.com/drush-ops/drush/pull/1230

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

Ah, didn't see that there was an issue above already, anyway, that has no PR yet.

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy commented

FYI the broken behavior in Drush is fixed now (as of 7 min ago).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

RavindraSingh’s picture

RavindraSingh CreditAttribution: RavindraSingh as a volunteer and at Srijan | A Material+ Company commented
Status: Closed (fixed) » Needs work
Issue tags: +drush

This issue still exists. So reopening again.
Here is the error example on running any drush commands in D8

 drush user-login

<em class="placeholder">Notice</em>: Use of undefined constant DRUPAL_BOOTSTRAP_CONFIGURATION - assumed 'DRUPAL_BOOTSTRAP_CONFIGURATION' in <em class="placeholder">drupal8_bootstrap()</em> (line <em class="placeholder">824</em> of <em class="placeholder">/Users/ravindrasingh/drush/lib/Drush/Boot/bootstrap.inc</em>).Ravindras-MacBook-Pro:barcelona ravindrasingh$
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs work » Fixed

@RavindraSingh there is no usage of DRUPAL_BOOTSTRAP_CONFIGURATION apart from one stale code comment. Feel free to file an issue against https://github.com/drush-ops/drush and when you do include steps to the reproduce and the version of Drush and commit hash of Drupal 8 you are using.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

This was fixed in drush a long time ago, make sure that you update to the most recent version.

RavindraSingh’s picture

RavindraSingh CreditAttribution: RavindraSingh as a volunteer and at Srijan | A Material+ Company commented

Thank you @alexpott and @Berdir for the information.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.