Problem/Motivation

hook_permission() is replaced by *.permissions.yml

Proposed resolution

Fix it as in this example.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#4 replace-2344215-4.patch653 bytespmagunia
#1 replace-2344215-1.patch696 bytespmagunia
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pmagunia’s picture

pmagunia
Primary language English
Location Philadelphia 🇺🇸
CreditAttribution: pmagunia commented
Status: Active » Needs review
FileSize
replace-2344215-1.patch696 bytes
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs review » Needs work

This looks really good and manual testing worked for me. Two small things caught my attention:

  1. +++ b/mathjax.permissions.yml
@@ -0,0 +1,5 @@
+  decription: 'Manage MathJax settings'

    We don't have a description now, so we should just leave it out. 

  2. +++ b/mathjax.permissions.yml
@@ -0,0 +1,5 @@
+
 

    There should be only one newline here.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Assigned: Unassigned » pmagunia
Priority: Normal » Critical
pmagunia’s picture

pmagunia
Primary language English
Location Philadelphia 🇺🇸
CreditAttribution: pmagunia commented
Status: Needs work » Needs review
FileSize
replace-2344215-4.patch653 bytes

Description and newline removed.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs review » Fixed

Fixed - thank you.

  • cilefen committed 6264041 on 8.x-2.x 
    Issue #2344215 by pmagunia | cilefen: Replace mathjax_permission() with...

Status: Fixed » Needs work

The last submitted patch, 4: replace-2344215-4.patch, failed testing.

The last submitted patch, 1: replace-2344215-1.patch, failed testing.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs work » Fixed

Ignore the failures - the patches can't apply because it has been committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.