Not sure how anyone is using the module atm on d6. All the "Add plugin" links are getting double encoded and are invalid.

For exampe, if I have a field to tamper named "Application Name" I get the following url for 'Add plugin':

<a href="/admin/build/feeds/tamper/add/testing_importer/Application%2520Name">Add plugin</a>

if should be:

<a href="/admin/build/feeds/tamper/add/testing_importer/Application%20Name">Add plugin</a>

I see that on line 33 of feeds_tamper.admin.inc it's getting rawurlencode'd before being sent to the l function. So l is getting 'Application%20Name' and returning 'Application%2520Name'.

For now, simply changing line 50 from

$add = FEEDS_TAMPER_UI_BASE . '/add/' . $importer->id . '/' . $i;

to:

$add = FEEDS_TAMPER_UI_BASE . '/add/' . $importer->id . '/' . $source;

Fixes the problem.

I'll post a proper patch when I get a chance.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

WorldFallz’s picture

Issue summary: View changes

changed the fix-- the original modification had other side effects. This one works without side effects.

WorldFallz’s picture

Issue summary: View changes
twistor’s picture

Status: Active » Needs work

It's intentionally getting double encoded. The fact that sources can be any string made things very difficult.

D7 contains a better fix. We just hex encode the values. It makes for ugly URLs, but oh well.
If you're going to try to fix it, then that should be the approach.

Something along these lines: http://cgit.drupalcode.org/feeds_tamper/commit/?id=8bb781e9f6a7818c7e0af...

twistor’s picture

Status: Needs work » Needs review
FileSize
4.83 KB

Status: Needs review » Needs work

The last submitted patch, 4: feeds_tamper-add_plugin_plugin-2343679-4.patch, failed testing.

twistor’s picture

Status: Needs work » Needs review
FileSize
5.65 KB

Status: Needs review » Needs work

The last submitted patch, 6: feeds_tamper-add_plugin_plugin-2343679-6.patch, failed testing.

twistor’s picture

Status: Needs work » Needs review
FileSize
6.67 KB

  • twistor committed d9c9f31 on 6.x-1.x
    Issue #2343679 by twistor: 'add plugin' plugin link gets double encoded...
twistor’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.