Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Not sure how anyone is using the module atm on d6. All the "Add plugin" links are getting double encoded and are invalid.
For exampe, if I have a field to tamper named "Application Name" I get the following url for 'Add plugin':
<a href="/admin/build/feeds/tamper/add/testing_importer/Application%2520Name">Add plugin</a>
if should be:
<a href="/admin/build/feeds/tamper/add/testing_importer/Application%20Name">Add plugin</a>
I see that on line 33 of feeds_tamper.admin.inc it's getting rawurlencode'd before being sent to the l function. So l is getting 'Application%20Name' and returning 'Application%2520Name'.
For now, simply changing line 50 from
$add = FEEDS_TAMPER_UI_BASE . '/add/' . $importer->id . '/' . $i;
to:
$add = FEEDS_TAMPER_UI_BASE . '/add/' . $importer->id . '/' . $source;
Fixes the problem.
I'll post a proper patch when I get a chance.
Comment | File | Size | Author |
---|---|---|---|
#8 | feeds_tamper-add_plugin_plugin-2343679-8.patch | 6.67 KB | twistor |
#6 | feeds_tamper-add_plugin_plugin-2343679-6.patch | 5.65 KB | twistor |
#4 | feeds_tamper-add_plugin_plugin-2343679-4.patch | 4.83 KB | twistor |
Comments
Comment #1
WorldFallz CreditAttribution: WorldFallz commentedchanged the fix-- the original modification had other side effects. This one works without side effects.
Comment #2
WorldFallz CreditAttribution: WorldFallz commentedComment #3
twistor CreditAttribution: twistor commentedIt's intentionally getting double encoded. The fact that sources can be any string made things very difficult.
D7 contains a better fix. We just hex encode the values. It makes for ugly URLs, but oh well.
If you're going to try to fix it, then that should be the approach.
Something along these lines: http://cgit.drupalcode.org/feeds_tamper/commit/?id=8bb781e9f6a7818c7e0af...
Comment #4
twistor CreditAttribution: twistor commentedComment #6
twistor CreditAttribution: twistor commentedComment #8
twistor CreditAttribution: twistor commentedComment #10
twistor CreditAttribution: twistor commented