This patch uses a blank div to allow block level ellements (like input> to go inside the form element per xhtml 1.0 specs. This patch works and validates, and is required for validation.

Robin

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dries’s picture

Yes/no? Please advise. If this patch is required, we might want to revise the call sites of form(). I believe some are adding divs to solve exactly this.

Robin Monks’s picture

You're right, some calls are using <div class="container-inline"> to do this. I'll find these instances and correct them, and then attach a new patch for this.

Robin

Robin Monks’s picture

Here is the new patch, which also removes unneeded (AFAIK) <div>'s from form's.

Robin

Stefan Nagtegaal’s picture

Could you please remove the spaces from your patch name? they break the link in e-mail clients quite often.. I would prefer not to use spaces at all inside patch filenames at all, I would encourage you to use something like 'patch_name.patch'..

Stefan

Robin Monks’s picture

Oh bother...

Robin

Dries’s picture

You can't remove container-inlines; these ensure that the form elements are displayed as display: inline. Removing container-inlines breaks those forms!

Steven’s picture

Applied to HEAD. I checked and couldn't see any redundant divs. They are all either for container-inline or for use in themes.

Anonymous’s picture