Problem/Motivation

#2335659: Remove FormState ArrayAccess usage from core broke this so ManyToOneHelper valueForm is shown when a ManyToOne filter is exposed.

+++ b/core/modules/views/src/Plugin/views/filter/ManyToOne.php
@@ -111,7 +111,7 @@ function operators() {
-    if (empty($form_state['exposed'])) {
+    if ($form_state->get('exposed')) {

E.g. if this is checked and you try to reset the exposed form filters, you will get a redirect loop.

Proposed resolution

Fix it

Remaining tasks

User interface changes

No more:

API changes

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

damiankloip’s picture

Status: Active » Needs review
FileSize
1.06 KB
1.64 KB
damiankloip’s picture

Issue summary: View changes
dawehner’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +VDC

OOH

The last submitted patch, 1: 2337897-tests-only-FAIL.patch, failed testing.

damiankloip’s picture

Issue summary: View changes
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 22c1362 and pushed to 8.0.x. Thanks!

  • alexpott committed 22c1362 on 8.0.x
    Issue #2337897 by damiankloip: Fixed ManyToOne filter should not display...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.