Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
We have a few migrations such as the d6_user migration which set a yml key of "no_stub" but in \Drupal\migrate\Plugin\migrate\process\Migration we use the key "no stub".
Proposed resolution
Rename to be consistent and add some tests.
Remaining tasks
Decide on whether to use "no_stub" or "no stub".
User interface changes
n/a
API changes
n/a
Comment | File | Size | Author |
---|---|---|---|
#8 | interdiff.txt | 947 bytes | benjy |
#8 | 2337749-8.patch | 3.57 KB | benjy |
#6 | interdiff.txt | 780 bytes | benjy |
#6 | 2337749-5.patch | 3.46 KB | benjy |
#4 | 2337749-4.patch | 3.52 KB | benjy |
Comments
Comment #1
benjy CreditAttribution: benjy commentedMy preference would be "no_stub". I think keys with spaces is a Drupal thing and I saw somewhere else in the issue queue we were trying to do away with them for permissions as well.
Comment #2
benjy CreditAttribution: benjy commentedComment #3
benjy CreditAttribution: benjy commentedComment #4
benjy CreditAttribution: benjy commentedPatch attached renames to no_stub and adds a test.
Comment #5
chx CreditAttribution: chx commentedjust getMock('interface') is enough -- interfaces dont have anything to disable (which is why we prefer them in typehint to classes).
Comment #6
benjy CreditAttribution: benjy commentedThanks for the review :)
Comment #7
dawehnerLet's use @coversDefaultClass and @covers so that we don't have to write a wrong description ;) Note: I took some of the code here over to https://www.drupal.org/node/2321609#comment-9145537
Comment #8
benjy CreditAttribution: benjy commentedThanks for the review.
Comment #9
dawehnerOOH we don't test the entity itself, got it!
Comment #10
alexpottCommitted 04fdb83 and pushed to 8.0.x. Thanks!
Removing unused uses on commit.