Remove usage of drupal_process_form().

Great! Can you also please remove the function?

Function also removed as mentioned in #3.

This will conflict (only slightly) with the very large #2335659: Remove FormState ArrayAccess usage from core, so postponing for now. Otherwise this would be RTBC.

The other issue went in, this can be rerolled.

I think this missed the RTBC tag after the reroll.

+++ b/core/modules/file/src/Controller/FileWidgetAjaxController.php
@@ -58,7 +58,7 @@ public function upload(Request $request) {
-    drupal_process_form($form['#form_id'], $form, $form_state);
+    \Drupal::formBuilder()->processForm($form['#form_id'], $form, $form_state);

+++ b/core/modules/system/src/Controller/FormAjaxController.php
@@ -64,7 +64,7 @@ public static function create(ContainerInterface $container) {
-    drupal_process_form($form['#form_id'], $form, $form_state);
+    \Drupal::formBuilder()->processForm($form['#form_id'], $form, $form_state);

We should inject the form builder into these two classes.

My first real take on dependency injection in D8. Try me :)

1. +++ b/core/modules/system/src/Controller/FormAjaxController.php
   @@ -28,13 +29,24 @@ class FormAjaxController implements ContainerInjectionInterface {
   +    $this->formBuilder = $form_builder;
   

   I like this solution, injecting the formBuilder into the constructor, but in #2355179 we didn't do it for form_get_cache. we should be consequent I think

2. +++ b/core/modules/system/src/Tests/Form/FormTest.php
   @@ -117,7 +117,7 @@ function testRequiredFields() {
   +          \Drupal::formBuilder()->processForm($form_id, $form, $form_state);
   

   we have 2 times the \Drupal::formBuilder called here, why we don't extract it into a variable?

So what you're saying is that:

1) I need to remove the injection again and that change needs to move to a new issue (as in #2355179)
2) Extract the formbuilder into a variable

I'm not really fond of retracing my steps, but i suppose splitting up the patch shouldn't be that difficult.
I suppose the new issue should wait till this one (once changed) goes in ...

Just because #2355179: Remove usage of form_get_cache() and form_set_cache() did it incorrectly doesn't mean this issue should. Please use injection.

#14.2 is just $form_builder = \Drupal::formBuilder(); above the first usage, and then $form_builder->processForm when its needed.

I'm noticing a bunch of \Drupal::formBuilder() statements in the /core/modules/system/src/Tests/Form/FormTest.php file, in different methods.

Are you suggesting, tim.plunkett, that all of these should be replaced by just a local variable ? Or did you only mean to do this when the variable is used multiple times in the same function ?

I'm assuming that in this case a class-wide formbuilder variable that is initialized in the setup method of the test would be the cleanest way to go. 5 extra lines just extracting into a local variable sounds like nonsense to me :)

Right ?

So, here is patch for latest D8 code version.

rudins, i appreciate the gesture but i was still waiting for some comment on the dependency injection.
You removed only part of it, yet as timplunkett mentioned in #16, dependency injection is to be preferred.
Also, i noticed a few unsused 'use' statements.

I'm uploading a new patch and interdiff in a minute

1. +++ b/core/modules/file/src/Controller/FileWidgetAjaxController.php
   @@ -10,10 +10,12 @@
   +use Drupal\Core\Form\FormBuilderInterface;
   ...
   +use Symfony\Component\DependencyInjection\ContainerInterface;
   

   These use statements aren't needed, the dependency injection is happening in the parent class FormAjaxController.

2. +++ b/core/modules/system/src/Controller/FormAjaxController.php
   @@ -71,7 +84,7 @@ public function content(Request $request) {
   -    drupal_process_form($form['#form_id'], $form, $form_state);
   

   As timplunkett mentioned in #16, dependency injection is preferred. You left in the added code for the form_builder to inject, but then removed the usage of the variable.

I've updated the patch, and patched some newly added \Drupal->formbuilder() call while i was at it.

After speaking to timplunkett, i'm moving the replacement of the other mentioned \Drupal::formbuilder() calls by a class-variable in the test classes to a new issue. I'll link it here (as it will be depending on this patch to go in first).

I moved the refactoring of the \Drupal::formBuilder() calls into issue #2362699: Replace multiple calls to \Drupal::formBuilder() in the Test classes

Look fine for me and no occurrence of drupal_process_form().

+++ b/core/includes/form.inc
@@ -54,18 +54,6 @@ function drupal_form_submit($form_arg, FormStateInterface $form_state) {
 /**
- * Processes a form submission.
- *
- * @deprecated in Drupal 8.x-dev, will be removed before Drupal 8.0.
- *   Use \Drupal::formBuilder()->processForm().
- *
- * @see \Drupal\Core\Form\FormBuilderInterface::processForm().
- */
-function drupal_process_form($form_id, &$form, FormStateInterface $form_state) {
-  \Drupal::formBuilder()->processForm($form_id, $form, $form_state);
-}

Plus don't remove the function in the same issue that removes all the usages.

Also can we attach the correct CR to this issue.

#25 has been addressed, patch is otherwise unchanged.

@ashutoshsngh interdiff please.
CR referenced.

This issue is a prioritized change (removing deprecated code usage) as per https://www.drupal.org/core/beta-changes and it's benefits outweigh any disruption. Committed 2ec3fbc and pushed to 8.0.x. Thanks!