Finish adding methods to FormStateInterface

Nice start :)

1. +++ b/core/lib/Drupal/Core/Form/FormState.php
   @@ -432,11 +426,357 @@ public function setFormState(array $form_state_additions) {
   +  public function setAlwaysProcess($always_process = TRUE) {
   +    $this->always_process = $always_process;
   ...
   +    $this->cache = $cache;
   ...
   +    $this->has_file_element = $has_file_element;
   ...
   +    $this->must_validate = $must_validate;
   ...
   +    $this->no_redirect = $no_redirect;
   ...
   +    $this->process_input = $process_input;
   ...
   +    $this->programmed = $programmed;
   ...
   +    $this->programmed_bypass_access_check = $programmed_bypass_access_check;
   ...
   +    $this->submitted = $submitted;
   ...
   +    $this->validation_complete = $validation_complete;
   

   1. All Boolean setters should force-cast the passed value to (bool), IMO.

   2. The class properties should use $lowerCamelCasing.

2. +++ b/core/lib/Drupal/Core/Form/FormState.php
   @@ -432,11 +426,357 @@ public function setFormState(array $form_state_additions) {
   +  public function setBuildInfo($build_info) {
   ...
   +  public function setButtons($buttons) {
   ...
   +  public function setGroups($groups) {
   ...
   +  public function setInput($input) {
   ...
   +  public function setRebuildInfo($rebuild_info) {
   ...
   +  public function setSubmitHandlers($submit_handlers) {
   ...
   +  public function setTriggeringElement($triggering_element) {
   ...
   +  public function setValidateHandlers($validate_handlers) {
   

   Type-hint array (interface change)

3. +++ b/core/lib/Drupal/Core/Form/FormState.php
   @@ -432,11 +426,357 @@ public function setFormState(array $form_state_additions) {
   +  public function forceUncached($no_cache = TRUE) {
   

   1. disableCache() or forceDisableCache()?

   2. This method should not accept a value; the value is always TRUE and it cannot be reverted (because doing so would break the code that originally asked for it to be disabled).

4. +++ b/core/lib/Drupal/Core/Form/FormState.php
   @@ -432,11 +426,357 @@ public function setFormState(array $form_state_additions) {
   +  public function setExecuted($executed = TRUE) {
   

   Like 'no_cache', 'executed' is also immutable, once it is TRUE.

5. +++ b/core/lib/Drupal/Core/Form/FormState.php
   @@ -432,11 +426,357 @@ public function setFormState(array $form_state_additions) {
   +  public function getMustValidate() {
   

   Boolean: isValidationEnforced() ?

6. +++ b/core/lib/Drupal/Core/Form/FormState.php
   @@ -432,11 +426,357 @@ public function setFormState(array $form_state_additions) {
   +  public function getProcessInput() {
   

   Boolean: isProcessingInput() ?

7. +++ b/core/lib/Drupal/Core/Form/FormState.php
   @@ -432,11 +426,357 @@ public function setFormState(array $form_state_additions) {
   +  public function getProgrammedBypassAccessCheck() {
   

   Boolean: isBypassingProgrammedAccessChecks() ?

1. +++ b/core/lib/Drupal/Core/Form/FormBuilder.php
   @@ -188,7 +188,7 @@ public function buildForm($form_id, FormStateInterface &$form_state) {
   +      $input = $form_state->getMethod()== 'get' ? $request->query->all() : $request->request->all();
   

   suggested to add isMethod('get') which allows you to ensure that 'GET' and 'get' works. @see Request Note: Here is also one space missing.

2. +++ b/core/lib/Drupal/Core/Form/FormBuilder.php
   @@ -239,7 +239,9 @@ public function buildForm($form_id, FormStateInterface &$form_state) {
   -        $cache_form_state = $form_state->getCacheableArray(array('always_process', 'temporary'));
   +        $cache_form_state = $form_state->getCacheableArray();
   +        $cache_form_state['always_process'] = $form_state->getAlwaysProcess();
   +        $cache_form_state['temporary'] = $form_state->getTemporary();
   

   What is the reason why this worked before?

3. +++ b/core/lib/Drupal/Core/Form/FormBuilder.php
   @@ -280,6 +282,8 @@ public function buildForm($form_id, FormStateInterface &$form_state) {
        $form = $this->retrieveForm($form_id, $form_state);
   +    // All rebuilt forms will be cached.
   +    $form_state->setCached();
   

   Is this a functional change? Just changing behavior here could be really fragile, for example for the views UI.

4. +++ b/core/lib/Drupal/Core/Form/FormBuilder.php
   @@ -376,9 +382,10 @@ public function retrieveForm($form_id, FormStateInterface &$form_state) {
   -    $callback = array($form_state['build_info']['callback_object'], 'buildForm');
   +    $callback = [$form_state->getFormObject(), 'buildForm'];
   

   <3

5. +++ b/core/lib/Drupal/Core/Form/FormBuilder.php
   @@ -462,35 +470,35 @@ public function processForm($form_id, &$form, FormStateInterface &$form_state) {
   -      if (!$form_state['rebuild'] && !FormState::hasAnyErrors()) {
   +      if (!$form_state->getRebuild() && !FormState::hasAnyErrors()) {
   

   Isn't rebuild a boolean, so isRebuild?

6. +++ b/core/lib/Drupal/Core/Form/FormState.php
   @@ -432,11 +421,359 @@ public function setFormState(array $form_state_additions) {
   +    $this->programmed = (bool) $programmed;
   ...
   +    $this->programmed_bypass_access_check = (bool) $programmed_bypass_access_check;
   

   Did we considered to throw an exception instead if you don't pass in a boolean? Just curious.

7. +++ b/core/lib/Drupal/Core/Form/FormState.php
   @@ -525,44 +873,24 @@ public function offsetUnset($offset) {
   +  /**g
   

   ...

8. +++ b/core/lib/Drupal/Core/Form/FormState.php
   @@ -692,19 +1048,19 @@ public function setRedirectUrl(Url $url) {
   +    if ($this->no_redirect) {
   

   Why is there no method for that? Can't you disable the redirection from outside?

9. +++ b/core/lib/Drupal/Core/Form/FormStateInterface.php
   @@ -167,8 +166,11 @@ public function getRedirect();
   +   *   $property is a string, it will return $storage[$property]. If $property is
   

   80 chars

10. +++ b/core/lib/Drupal/Core/Form/FormStateInterface.php
    @@ -167,8 +166,11 @@ public function getRedirect();
    +   *   an array, each element of the array will be used as a nested key. If
    +   *   $property = ['foo', 'bar'] it will return $storage['foo']['bar'].
    

    What actually happened with the 'foo][syntax'? Did we dropped them at some point?

11. +++ b/core/lib/Drupal/Core/Form/FormStateInterface.php
    @@ -509,4 +564,406 @@ public function prepareCallback($callback);
    +   * @see \Drupal\Core\Form\FormState::$limit_validation_errors
    ...
    +   * @see \Drupal\Core\Form\FormState::$limit_validation_errors
    

    I wonder why you have added those @see statements but just for some of them. Doesn't those bits of documentation makes more sense on the interface? Otherwise they would make more sense on the actual implementation, if this is an implementation detail.

12. +++ b/core/lib/Drupal/Core/Form/FormStateInterface.php
    @@ -509,4 +564,406 @@ public function prepareCallback($callback);
    +   *  If TRUE, the form will not redirect.
    ...
    +   *  If TRUE, the form will not redirect.
    

    Nitpick alarm: Not enough spaces

13. +++ b/core/lib/Drupal/Core/Form/FormStateInterface.php
    @@ -509,4 +564,406 @@ public function prepareCallback($callback);
    +   */
    +  public function isRedirectDisabled();
    

    So there is a method, see above.

14. +++ b/core/lib/Drupal/Core/Form/FormStateInterface.php
    @@ -509,4 +564,406 @@ public function prepareCallback($callback);
    +   * @param array|null $submit_handlers
    +   *   An array of submit handlers, or NULL if there are none.
    ...
    +   * @return array|null
    +   *   An array of submit handlers, or NULL if there are none.
    +   */
    +  public function getSubmitHandlers();
    

    I don't see a point in differentiating NULL from [] here.

15. +++ b/core/modules/views/includes/ajax.inc
    @@ -17,12 +17,14 @@
    -  $form_state->setIfNotExists('build_info', array(
    -    'args' => array(),
    -  ));
    +  if (!$form_state->has('rerender')) {
    +    $form_state->set('rerender', FALSE);
    +  }
    +  // Do not overwrite if the redirect has been disabled.
    +  if (!$form_state->isRedirectDisabled()) {
    +    $form_state->disableRedirect(!empty($form_state['ajax']));
    +  }
    +  $form_state->disableCache();
    

    What happens with updating the args?

16. +++ b/core/modules/views/src/Plugin/views/exposed_form/ExposedFormPluginBase.php
    @@ -129,14 +129,13 @@ public function buildOptionsForm(&$form, FormStateInterface $form_state) {
    -      'display' => &$this->view->display_handler->display,
    ...
    +      ->set('display', $this->view->display_handler->display)
    

    Mhh,, are we sure we don't introduce a regression here? display is not an object, it is just an array.

17. BaseFormIdInterface mentions $form_state->getBuildInfo()['base_form_id'], did you considered adding a dedicated methdo for that?

+++ b/core/modules/user/src/Tests/UserAccountFormFieldsTest.php
@@ -31,9 +31,8 @@ class UserAccountFormFieldsTest extends DrupalUnitTestBase {
-    $install_state = install_state_defaults();
...
-    $form_state['build_info']['args'][] = &$install_state;
+    $form_state['build_info']['args'][] = install_state_defaults();

Doens't that change the behaviour? and why do you not use getBuildInfo?

1) what about isMethodType maybe?
2) Okay cool
3) As long views preview, UI and exposed forms still works fine, cool!
6) Yeah just was throwing out some ideas from time to time
15) Lovely!
16) Mh, so can't we somehow get a reference here, maybe a set alternative with a reference?

Cool, IS?

+++ b/core/lib/Drupal/Core/Form/FormBuilderInterface.php
@@ -79,7 +79,7 @@ public function buildForm($form_id, FormStateInterface &$form_state);
+   * finished. If a validate or submit handler set $form_state->isRebuilding() to

@@ -98,7 +98,7 @@ public function buildForm($form_id, FormStateInterface &$form_state);
+   *   in $old_form and for which $form_state->getRebuildInfo()['copy'][PROPERTY]

@@ -293,7 +293,7 @@ public function prepareForm($form_id, &$form, FormStateInterface &$form_state);
+   *   $form_state->getValues() and setting $form_state->isRebuilding(). The form

More then 80 chars.

Thank you @tim.plunkett for fixing those issue. This is RTBC IMO.

Let's get them CRs updated :)

Committed ee6ddbe and pushed to 8.0.x. Thanks!