Move update classes from preprocess to templates

@dstorozhuk - I don't want to rush you but have you started work on this? I'm just making sure we get patches on all these sub-issues to keep our momentum up :)

If you won't have time you can unassign. I'll give you a couple days to respond as to whether you are working on this or not. Thanks!

Up for grabs.

+++ b/core/modules/update/templates/update-project-status.html.twig
@@ -58,11 +67,18 @@
+  set extra_attributes = [
+    project.status == constant('UPDATE_NOT_SECURE') ? 'project-not-secure',
+    project.status == constant('UPDATE_REVOKED') ? 'project-revoked',
+    project.status == constant('UPDATE_NOT_SUPPORTED') ? 'project-not-supported',
+  ]
+%}
 <div class="info">
   {% if extras %}
     <div class="extra">
       {% for extra in extras %}
-        <div{{ extra.attributes }}>
+        <div{{ extra.attributes.addClass(extra_attributes) }}>

These are extra classes, not extra attributes.

Off-topic: how do you set extra attributes in Twig? Doesn't seem to be supported?

This is the only thing I could find:

+++ b/core/modules/update/update.report.inc
@@ -290,32 +290,26 @@ function template_preprocess_update_project_status(&$variables) {
+  $variables['status']['attributes'] = new Attribute;

new Attribute() per https://www.drupal.org/coding-standards#constructors.

Rolled in here. Manually tested and RTBC. Nice work!

Committed and pushed to 8.x. Thanks!

While I was working on #2408499: Rewrite update components inline with our CSS standards I noticed that we still have classes at least in core/modules/update/src/Form/UpdateManagerUpdate.php

example:

1. rows 245-252
    $headers = array(
      'title' => array(
        'data' => $this->t('Name'),
        'class' => array('update-project-name'),
      ),
      'installed_version' => $this->t('Installed version'),
      'recommended_version' => $this->t('Recommended version'),
    );

I also noticed that a lot of markup is coming from somewhere else than templates, so when we start to add new classes to table-elements I'm pretty sure we will get even more classes to non-template files.

As I tried to point out there: https://www.drupal.org/node/2408499#comment-9591331 testing these templates, CSS and which classes are being used and where is relatively difficult, so we should double check things.

@DickJohnson - in general we knew going into this (banana) that we wouldn't be eliminating all classes. They are coming from too many places. But we can reduce at least. Thanks for looking into that!