Move html classes from preprocess to templates

I think I see a path now. We can pass the node type as a variable that makes it way to the html template, and do the same for the maintenance. Those classes can be removed from preprocess maintenance and maybe handled directly in _html or _page.

I think we may end up merging the html and page issues. All the page functions are really just adding classes to and . I don't see any getting added to the markup in the page template.

I only meant merging the two banana phase 1 issues together, since they are related. We certainly wouldn't try merging the templates together here (or at all.) :)

#2234331: Change the body classes to follow Drupal 8 CSS standards is in.

Functionally, the patch in #32 looks good. We'll have to rework some of the comments, but I think that is it.

Regarding the node classes, we have a dilemma. I don't think there is a way we can move it (it is just the node--type-X class) to the html template. Node is a required module, but it's still a case of a module manipulating another module's template. Based on what we're doing, philosophically, node should have it's own html template (html--node.html.twig,) but I'm willing to bet no one will vote for that. That would mean leaving it in preprocess.

A consideration would be the html--node.html.twig template being in Classy. We'll end up removing the node--type-X class from the system module's html template, so the only copy of the template that needs to exist is in Classy, not in the system or node module.

We actually need more Twig blocks EVERYWHERE. We need a whole template strategy, which I don't think we'll be able to get to in D8.

+++ b/core/modules/system/templates/html.html.twig
@@ -26,6 +28,12 @@
+    is_front ? 'path-frontpage' : 'path-' ~ root_path|clean_class,

This won't work. We've lost the is_front variable, which is now only available to page.html.twig.

+++ b/core/includes/theme.inc
@@ -1359,23 +1359,12 @@ function template_preprocess_html(&$variables) {
   $path = \Drupal::request()->getPathInfo();
...
+  $variables['root_path'] = explode('/', $path)[1];

I was thinking, with this code, root_path will be empty if on the frontpage. Could we do...

not root_path ? 'path-frontpage' : 'path-' ~ root_path|clean_class

Does that make sense?

Also, I was talking to Cottser about this and it seems ok to move the node class stuff into html.html.twig. We already have precedent doing that with page. If we figure out how to move it, we can completely get rid of node_preprocess_html which is only adding "node--type-[type]".

...adding beta eval text to issue summary.

It would be nice to manual test. Check that the path-frontpage and root_path are working correctly on various pages. Also, that it works correctly when Drupal is installed in a subdirectory.

We need to fix the comments. Also, I think we can add the node type class, which lauriii had in #18. I think we'll be ok with that, and it takes care of node_preprocess_html. The other solution would be to add the class in node--html.html.twig (extending html.html.twig.) We could do that just in Classy, without an extra template in core, but I don't think we need to do that now. We can sort that out in the phase 2 follow up.

I'm striking out the install page /maintenance page stuff since I don't see anything to move.

Not sure about the failure. Those tests passed locally. Maybe just testbot acting up?

I modified some comments and added the node class. Thoughts?

I'm all for simplifying. When I dump node here I get NULL. It is not loaded for preprocess_html but it is for preprocess_page. Does that not make it through? Is it worth loading again? (And it's probably node.bundle?)

How about this? Not sure if it's the best approach or wasteful. I loaded the node for the html template and got rid of the node_preprocess_html completely. I was curious and did a quick and dirty profiling of a node page to see if anything bad happened. The runs actually all came back slightly faster. *shrug*

Alrighty, though we could make the same argument for the html template that is made for the page template, in regards to having the node data there. But node data probably isn't particularly useful in the html template.

I'm hiding the last patch, so lets review with #50 instead.

It looks like this commit introduced a bug. #2404929: Path class on <body> may be language specific, results in CSS bugs

Should be easy to fix.

It is being fixed here #2411597: Class 'path-frontpage' missing from <body>