Follow-up to #2251113: Use container parameters instead of settings

Problem/Motivation

#2251113: Use container parameters instead of settings introduced new default.services.yml file to override code services which is something that shouldn't be version controlled.

Proposed resolution

Add sites/*/*services*.yml in example.gitignore list

Remaining tasks

User interface changes

N/A

API changes

N/A

CommentFileSizeAuthor
#3 2326913-services-gitignore-3.patch333 bytesvijaycs85
#1 2326913-services-gitignore-1.patch309 bytesvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Active » Needs review
FileSize
2326913-services-gitignore-1.patch309 bytes

Status: Needs review » Needs work

The last submitted patch, 1: 2326913-services-gitignore-1.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Title: Add sites/*/*services*.yml to .gitignore » Add sites/*/*services*.yml to example.gitignore
Status: Needs work » Needs review
FileSize
2326913-services-gitignore-3.patch333 bytes
vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Issue summary: View changes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

+1

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Good catch.

Committed and pushed to 8.x. Thanks!

  • webchick committed 9e11fdf on 8.0.x 
    Issue #2326913 by vijaycs85: Add sites/*/*services*.yml to example....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.