Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
See parent issue.
Proposed resolution
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#23 | interdiff.txt | 1.9 KB | tim.plunkett |
#23 | 2326875-file-23.patch | 28.66 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettWorking on this
Comment #2
tim.plunkettComment #4
tim.plunkettRerolled for now without the hook_element_info() removal in light of #2326409: Annotate render element plugins
Comment #6
tim.plunkettComment #8
tim.plunkettfile_managed_file_validate() was used in one other place.
Comment #10
tim.plunkettComment #11
jibranWe can use static method here.
Comment #12
tim.plunkettOkay
Comment #15
tim.plunkettDuh! We need to specify the #value_callback until its a proper callback.
Comment #16
tim.plunkettComment #17
jibranIf you disagree with 1 and 2 it's fine by me perhaps we can add @todo (with issue id) for those methods.
IMO we can also move this function here.
IMO we have to move this function as well to this element file. Right know we are not using it at anyplace other then this.
Can't we use controller/routes here?
Minor doc update
file_managed_file_process
doesn't exist anymore andfrom_builder
is deprecated. There is one more ref tofile_managed_file_process
just abovefile_managed_file_submit
we have to update that as well.Comment #18
iMiksuThis should resolve #17.4.
Comment #19
tim.plunkettComment #22
jibranthis issue is in so needs reroll.
Comment #23
tim.plunkettComment #24
jibranThank you married guy :D
Comment #25
alexpottCommitted 69be11e and pushed to 8.0.x. Thanks!