setSetting('default_value') => setDefaultValue()

CommentFileSizeAuthor
#5 menu-2324825-5-test-only.patch1.45 KBjibran
#4 menu-2324825-4.patch3.88 KBdawehner
#3 Add menu link Site Install.png68.93 KBBerdir
#1 menu-link-defaults-2324825-1.patch2.43 KBBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Active » Needs review
FileSize
menu-link-defaults-2324825-1.patch2.43 KB

Here is a patch. I don't think we need to set explicit defaults for things like an empty description. and title is required, so pointless to have an empty default value.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Issue tags: +Needs tests

oops, thanks. Should figure out why tests are not catching this

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
FileSize
Add menu link Site Install.png68.93 KB

Add form, without default values.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: -Needs tests
FileSize
menu-2324825-4.patch3.88 KB

Added some proper test coverage here.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
FileSize
menu-2324825-5-test-only.patch1.45 KB

Adding test only patch. To show the fails.

Status: Needs review » Needs work

The last submitted patch, 5: menu-2324825-5-test-only.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs work » Reviewed & tested by the community

Thanks for the patch and tests @Berdir and @dawehner

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

  • webchick committed 2e992d5 on 8.0.x 
    Issue #2324825 by jibran, dawehner, Berdir: Fixed MenuLinkContent::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.