Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi!
The W3C feed validator says that:
Sorry
This feed does not validate.
line 16, column 40: pubDate must be an RFC-822 date-time: Mo, 10 Mär 2008 17:42:43 +0100 (30 occurrences) [help]
<pubDate>Mo, 10 Mär 2008 17:42:43 +0100</pubDate>
Obviously the date is being localized what is not RFC-822 conform. (Mär instead of Mar)
I will provide more information if needed!
Andreas
Comment | File | Size | Author |
---|---|---|---|
#18 | 232433.d5.node_.pubDate.patch | 1.18 KB | Damien Tournoud |
#12 | d7.node_.pubDate.patch | 1.22 KB | mfb |
#12 | d6.node_.pubDate.patch | 2.94 KB | mfb |
#11 | en_rss_date-232433-11.patch | 1.01 KB | floretan |
#10 | enrssdate2.patch | 1.05 KB | macgirvin |
Comments
Comment #1
Shnoulle CreditAttribution: Shnoulle commentedSame problem with 6.1 and french langage.
puDate had to be in EN .
(with rss feeder (Thunderbird, google, aggregator of drupal ...) All rss have the same date.)
rss.xml is OK, but not /blog/feed
Thank you
Comment #2
ptilu8 CreditAttribution: ptilu8 commentedSame problem
Drupal6.1
French
Invalid PubDate format
rss.xml not OK
Thx
Comment #3
macgirvin CreditAttribution: macgirvin commentedGive this patch a try. I haven't tested it myself because I don't have any translations but theoretically it should fix the problem. It simply forces the date to be in English when filling in the pubDate field contents for the feed.
Comment #4
ptilu8 CreditAttribution: ptilu8 commentedTested, seems ok for me...
Comment #5
macgirvin CreditAttribution: macgirvin commented...If we can get one more person to test this, I'd be happy to bump it up a notch so that the change gets committed. As mentioned previously, I don't have the localisation framework to test it myself.
It's a quite serious bug for anybody not on an English default system; as all their feeds are non-validating and potentially unusable. It would be quite appropriate IMHO to mark it as 'critical'.
Comment #6
hsiegel CreditAttribution: hsiegel commentedJust tested this and it works for me (german language).
This patch should be added as soon as possible, as all 6.1 users seem to have the same issue with their rss-feeds if they changed their installation from english-default.
Thx
Comment #7
Damien Tournoud CreditAttribution: Damien Tournoud commentedHum. I don't really understand why there is not the same problem on Drupal 5. Could someone clarify that?
From
node_feed()
in Drupal 5:... and
format_date()
does not support the$langcode
argument, which has been added in Drupal 6.Comment #8
Damien Tournoud CreditAttribution: Damien Tournoud commentedOh, and (if confirmed) this is critical (it breaks the whole feed creation mecanism), and bugs should get corrected in the current development version, than back-ported.
Comment #9
Dries CreditAttribution: Dries commentedThe patch is not formatted properly and therefore won't apply. It needs to be re-rolled with proper line-breaking. Thanks.
Comment #10
macgirvin CreditAttribution: macgirvin commentedPatch re-rolled - not certain how the lines got folded.
Comment #11
floretan CreditAttribution: floretan commentedFile was patching node.module.orig, which doesn't exist. Fixed in attached patch.
Besides the very long line of code (which was already there before), this looks good.
Comment #12
mfbThis is a critical bug for drupal 6.
Here's what I think is a more correct patch: the formatting has to be correct so we should use PHP date functions, not format_date().
Comment #13
macgirvin CreditAttribution: macgirvin commented+1
I concur.
Comment #14
mfbFixing component.
Comment #15
Dries CreditAttribution: Dries commentedI've committed this patch to CVS HEAD and DRUPAL-6. Thanks mfb.
Comment #16
Dries CreditAttribution: Dries commentedComment #17
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #18
Damien Tournoud CreditAttribution: Damien Tournoud commented#212864: rss feed wrong date was also committed to the DRUPAL-5 branch, but only got released yesterday with Drupal 5.8. Here is a reroll.
Comment #19
drummCommitted to 5.x.
Comment #20
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #21
Bilalx CreditAttribution: Bilalx commentedStill have the same problem with the latest version of drupal
Comment #22
mfb@Jaafarix: Not sure why there'd still be an issue since this patch is in 6.12: http://cvs.drupal.org/viewvc.py/drupal/drupal/modules/node/node.module?a...
Comment #23
Bilalx CreditAttribution: Bilalx commentedYes I checked the patch against 6.12 and it is there. Still the publication date are in french for me, both with views and rss.xml and the feed does not validate.
I removed the date for now thanks to theming but it would be nice to have the english date in feed instead of the french one
Comment #24
Damien Tournoud CreditAttribution: Damien Tournoud commented@Jaafarix: what you are seeing is a Views issue. Please see #461842: Views translates pubdate of rss feed for details.
Comment #25
Bilalx CreditAttribution: Bilalx commentedI tried the patch and i have english dates now.
Thank you very much :).