Menu dropdown missing from "Normal menu entry" section in Views

mhhh there should be actually a parent menu selector, odd.

here is a patch.

Haha, did I really thought that this is a simple issue?

Part of the problem was that the menu parent selector did not return a selection element at all if the default value was invalid or empty.

@Xano
I thought this was done on purpose?

There we go.

Here is a test.

#12 was a different issue. Reversed the out of scope/buggy change

I thought this was done on purpose?

I don't know why it was done, but it's inconsistent with how we handle form elements elsewhere (default values do not influence the available options) and it directly prevented the selector from showing for new page displays. The only other option would have been to set a sensible parent item value in the page display by default, and to keep the value valid throughout the page's lifetime, which is harder to do.

I don't know why it was done, but it's inconsistent with how we handle form elements elsewhere (default values do not influence the available options) and it directly prevented the selector from showing for new page displays. The only other option would have been to set a sensible parent item value in the page display by default, and to keep the value valid throughout the page's lifetime, which is harder to do.

Well, this is an entire different discussion. The interface clearly says that in case you have no matching $menu_parent, the resulting array will be empy. Showing

Fixed it.

Muh.

reroll

Marked #2343581: Not possible to assign menu item to existing view unless it already has a menu item a duplicate. That was critical, so elevating this one as well.

Marking for D8MIAMS which are the issues we'd love to get solved for the D8 multilingual site building lab on Wed. We do create some views. I looked into reviewing this issue but I don't think I have the background info that would be useful to asses why all the changes are going on in blocks, displays, etc :/

I just followed the instructions in the issue summary on simplytest.me - and am definitely now seeing a drop down to choose the menu.

Screen grab:

1. +++ b/core/modules/views/tests/modules/views_test_config/test_views/views.view.test_page_display_menu.yml
   @@ -97,6 +97,24 @@ display:
   +  page_5:
   +    display_options:
   +      path: test-path
   +      title: 'Tests a menu with a not existing parent'
   

   Use "non-existing parent" instead of "not existing parent".

2. +++ b/core/modules/views_ui/src/Tests/DisplayPathTest.php
   @@ -16,13 +16,20 @@
      /**
   +   * Modules to enable.
   +   *
   +   * @var array
   +   */
   +  public static $modules = array('menu_ui');
   +
   

   Use {@inheritdoc}.

3. +++ b/core/modules/views_ui/src/Tests/DisplayPathTest.php
   @@ -16,13 +16,20 @@
   -  public function testPathUI() {
   +  public function ptestPathUI() {
        $this->doBasicPathUITest();
   

   This test shouldn't be disabled.

4. +++ b/core/modules/views_ui/src/Tests/DisplayPathTest.php
   @@ -63,7 +70,7 @@ protected function doAdvancedPathsValidationTest() {
   -  public function testDeleteWithNoPath() {
   +  public function ptestDeleteWithNoPath() {
   

   Test is disabled.

During testing I get an exception when assigning a menu item to a Views page and then disabling the view:

Uncaught PHP Exception Symfony\Component\Routing\Exception\RouteNotFoundException: "Route "view.bdsggds.page_1" does not exist." at /home/pieter/v/drupal/drupal/core/lib/Drupal/Core/Routing/RouteProvider.php line 147

I can't replicate the exception any more :-/

I fixed my remarks and did some little cleanups.

I have one question about this patch, but this is a pretty weird bug, so that shouldn't hold this up. Hence, marking RTBC.

1. +++ b/core/modules/views/src/Plugin/views/display/Block.php
   @@ -316,14 +355,16 @@ public function usesExposed() {
   +    if ($this->entityManager->hasDefinition('block')) {
   

   It might be that I'm missing something but why would the Block display even be available at all, if block module is not installed? I.e. wouldn't it be also possible to just declare provider = "block" in the annotation? May be a separate issue, though.

2. +++ b/core/modules/views_ui/src/Tests/DisplayPathTest.php
   @@ -96,6 +103,25 @@ public function testMenuOptions() {
   +    $menu_options = (array) $menu_parent[0]->option;
   +    unset($menu_options['@attributes']);
   

   Awesome trick!!!

Hm. Trying to kick the bot a bit.

Committed and pushed to 8.x. Thanks!