Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #2034879: [Meta] Fix documentation that refers to enabling/disabling of modules
66 instances of the word "enabl". Some may not need to be changed.
40 instances of the word "disabl". Some may not beed to be changed.
Comment | File | Size | Author |
---|---|---|---|
#12 | interdiff.txt | 2.62 KB | LinL |
#12 | fix_docs_2318755-12.patch | 11.01 KB | LinL |
#7 | fix_docs_2318755-7.patch | 11.09 KB | Devin Carlson |
#6 | fix_docs_2318755-4.patch | 2.91 KB | effulgentsia |
#4 | fix_docs_2318755-4.patch | 2.89 KB | Devin Carlson |
Comments
Comment #1
melbs CreditAttribution: melbs commentedComment #2
melbs CreditAttribution: melbs commentedComment #3
xjmComment #4
Devin Carlson CreditAttribution: Devin Carlson commentedAttaching the patch from #2318813-5: Comment module: Fix documentation that refers to enabling/disabling of modules which was for block.module but was posted in the issue for comment.module.
Credit goes to @Lowell.
Comment #6
effulgentsia CreditAttribution: effulgentsia commentedJust a reroll. I think the patch is still incomplete though. For example, there are tests that say "Modules to enable." that need to be fixed.
Comment #7
Devin Carlson CreditAttribution: Devin Carlson commentedAdded the missing fixes to #6.
Comment #8
LinL CreditAttribution: LinL commentedLooks good. I searched core/modules/block for enabl and disabl and there are none that relate to modules. RTBC.
Not related to this issue, but as we are changing the line anyway, I wonder if we can change "the the" to "the" here? If not, I'll file a separate issue.
Comment #9
LinL CreditAttribution: LinL commentedComment #10
catchGreat to see these sub-issues.
Couple of comments:
I don't think this can be right. If a module is uninstalled the block will disappear altogether. However isn't this talking about block being disabled anyway?
We should open a follow-up to review this. It shouldn't be possible to get into this state by uninstalling a module - all the blocks should be removed then.
Comment #11
jhodgdonWe already have an issue open for updating hook_help for the Block module but yes let's remove "the the" here. I mentioned it on #2349907: Review and fix block hook_help text in case it doesn't get fixed here.
I also agree with the block rehash assessment -- the code comment is really talking about disabled blocks, not disabled modules.
Comment #12
LinL CreditAttribution: LinL commentedRerolled. I changed the block rehash comment and also deleted the extra "the".
Comment #13
catchOpened the follow-up for that exception #2385517: Block initialization eats exceptions if a module is missing.
Changes look good so moving back to RTBC.
Comment #15
jhodgdonThis has been properly beta-evaluated, and is purely docs fixes. Looks good to me too. Committed to 8.0.x.