Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Per issue #2034879: [Meta] Fix documentation that refers to enabling/disabling of modules, this issue is for fixing the enable/disable to install/uninstall language in the REST module
Comment | File | Size | Author |
---|---|---|---|
#31 | fixing_enable_to_install-2318753-31.patch | 8.43 KB | Devin Carlson |
#28 | fixing_enable_to_install-2318753-28.patch | 8.7 KB | amitgoyal |
Comments
Comment #1
greenhodge CreditAttribution: greenhodge commentedHere we will be fixing the language in the rest_help function in
rest.module
from:In order to use REST on a web site, you need to install and enable modules that provide
to
In order to use REST on a web site, you need to install modules that provide
Comment #2
greenhodge CreditAttribution: greenhodge commentedComment #3
greenhodge CreditAttribution: greenhodge commentedComment #4
Les LimComment #5
Les Lim"Enabling" should be "Installing" here.
Otherwise, this looks good!
Comment #6
greenhodge CreditAttribution: greenhodge commentedNew patch responding to Les Lim's thing he pointed out.
Comment #7
Les LimLooks RTBC to me.
Leaving as "critical" since the parent meta is critical.
Comment #8
Les LimTaking another look.
Comment #9
Les LimCode comments throughout Rest module tests still refer to "Modules to enable."
Comment #10
Les LimComment #11
greenhodge CreditAttribution: greenhodge commentedWe believe we may have finally fixed them ALL.
Comment #12
greenhodge CreditAttribution: greenhodge commentedComment #13
greenhodge CreditAttribution: greenhodge commentedAttempting to fix the end-of-line unhappiness
Comment #14
Les LimInline code comments should still wrap at 80 characters, including the spaces in the indent.
Comment #15
Les LimComment #24
xjmComment #25
xjmLooks like the patches don't apply to the 8.0.x branch tip, so this will need a reroll. Thanks all!
Comment #26
xjmLet's actually make the child issues normal since these are very small patches and the critical meta will still make sure completing the task blocks release.
Comment #27
greenhodge CreditAttribution: greenhodge commentedComment #28
amitgoyal CreditAttribution: amitgoyal commentedReroll of #13 along with fixes in #14.
Comment #31
Devin Carlson CreditAttribution: Devin Carlson commentedReroll of #28.
I also verified that it covers all of the instances of enable/disable.
Comment #32
effulgentsia CreditAttribution: effulgentsia commentedLooks good.
Comment #33
effulgentsia CreditAttribution: effulgentsia commentedComment #34
alexpottThis issue is a unfrozen change (documentation) as per https://www.drupal.org/core/beta-changes and it's benefits outweigh any disruption. Committed d3f5497 and pushed to 8.0.x. Thanks!