Forena's 7.x-4x-beta3 version now also displays some forena related info on Drupal's status report (within /admin/reports/status). However some minor refinements for the display of these messages seem appropriate, i.e. related to:

  • the info about the Forena report directory.
  • the info about the SVGGraph support (and similarly the dataTables support, and the PDF support libraries).

The additional comments in this issue provide some more details about the suggested refinements.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pierre.Vriens’s picture

Regarding the info about the Forena report directory:

  • If the directory does not exist (yet or anymore), you get a message containing "The directory must be writable by the web user in order to create custom reports. ", as illustrated in attached Rpt-Dir-Original-Error-Message.png. This message appears to be a bit misleading, instead it should indicate that the directory does not exist, something as illustrated in attached Rpt-Dir-Refined-Error-Message.png.
  • If the directory does exist, and is writable by the web user, no information about the report directory is included in the status report. It appears that in this case, a confirmation that the setup of the directory is correct is more appropriate. A way to do so is illustrated in attached Rpt-Dir-Status-OK-Message.png.

Refer to attached patch file to implement these refinements.

Pierre.Vriens’s picture

Regarding the info about the SVGGraph support (and similarly the dataTables support):

  • Forena checks if the required SVGGraph library is present in the sites/all/libraries folder (with an exact name like 'SVGGraph', case sensitive also). If the check succeeds, the status report includes a line as illustrated in attached SVGGraph-Original-Enabled-Message.png (note the "Enabled" in it). If the check fails, the line shown is as illustrated in attached SVGGraph-Original-Not-Enabled-Message.png (note the "Not Enabled:" in it).
  • Unless you start looking in the forena code, it isn't obvious for a forena-novice to figure out where this message comes from, and what you should do to actually "enable" SVGGraph support (i.e.: download the SVGGraph directory in the sites/all/libraries, and don't search for any forena related admin setting related to it).
  • To make the SVGGraph support more intuitive, consider refining these enabled/not enabled messages as illustrated in attached SVGGraph-Refined-Enabled-Message.png and SVGGraph-Refined-Not-Enabled-Message.png.

Similar remark for the dataTables support.

Refer to attached patch file to implement these suggested refinements.

Pierre.Vriens’s picture

Assigned: Pierre.Vriens » Unassigned
Status: Active » Needs review
metzlerd’s picture

Status: Needs review » Needs work

It's unclear from the existing message what I'm supposed to do. Would it be possible to add a link in that message to the appropriate configuration page so that the user is taken to the page where they need to confirm the configuration of the reports directory?

Pierre.Vriens’s picture

David, here is a patch to replace my prior patch in #1, containing the corrections you asked about in #4. This patch is also re-rolled against current dev version (instead of beta3 before), and using a path relative to the forena dir. Attached are also 2 new png files to illustrate my newest test results, and which replace the Rpt-Dir-Refined-Error-Message.png from my #1 (the other pngs in #1 are unchanged).

If you agree, let me know if you want me to apply it to the dev version (alternatively go ahead to get it applied).

Pierre.Vriens’s picture

Status: Needs work » Needs review
FileSize
1.19 KB

David, here is a patch to replace my prior patch in #2. This patch is re-rolled against current dev version (instead of beta3 before), and using a path relative to the forena dir. No other (functional) changes were applied (as compared to #2), so the png files there are still valid.

If you agree, let me know if you want me to apply it to the dev version (alternatively go ahead to get it applied).

With that I think I'm finished with this issue, unless anybody has remaining requests. If you agree, please go ahead and mark this issue as fixed.

Pierre.Vriens’s picture

Title: Refine status messages for Report Directory and for SVGGraph/dataTables support » Refine status msgs for Rpt Dir and supported libraries
Parent issue: » #2354565: Forena 7.x-4.0 Release
metzlerd’s picture

Status: Needs review » Reviewed & tested by the community

This looks good to me.

Pierre.Vriens’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Just committed the proposed changes ... and changing this issue to fixed now ... With that, #2354565: Forena 7.x-4.0 Release has nothing but green child pages! So David, what's next?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.