Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #2285413: [Meta] Standardize entity route names. See there for details.
entity_test module has a number of entities that are subclasses of entity_test, and sometimes reuse its links and sometimes not. I don't fully grok what's going on there so this is a bit harder to convert.
I am assigning to fago for help on what to do with those. :-) fago, please advise.
Comment | File | Size | Author |
---|---|---|---|
#14 | 2314889-entity_test-routes-14.patch | 12.31 KB | andypost |
Comments
Comment #1
dawehnerSome of them also points to routes which do not exist. I think we should in general standardize the available links.
Comment #2
Temoor CreditAttribution: Temoor commentedUpdated route names, however not sure what should be done with unused items, so they are renamed too.
Comment #4
andypostFix other routes
Comment #6
andypostFound a bug in comment tests, also fixed missed redirect in add form
Comment #8
andypostAdd missed routes
Comment #10
andypostProper fix for routes, should be green
Comment #11
andypostFix one more inconsistency
Comment #12
andypostI think we should add this within the conversion because that conversion uncovered that test incomplete
Comment #13
andypost@fago Crell said that it needs your review
Comment #14
andypostre-roll
Comment #15
andypostMeta issue closed #2285413: [Meta] Standardize entity route names because this only one left
Suppose @Berdir knows entity_test better after #1976158: Rename entity storage/list/form/render "controllers" to handlers ;)
Comment #16
fagoNot sure what the question is here even?
Entity test types is just a bunch of entity types used in various test cases. A lot of them only extend EntityTest to add in some custom entity definitions which is then used/tested in a test case. If links are unused / wrong they can/should be removed of course.
Comment #17
dawehner@andypost
As you probably saw some of these routes defined here aren't defined but well, this isn't changed but this patch.
Comment #18
andypostI checked this again, and really can't find unused ones...
delete - fine
this is used in tests
Comment #19
dawehnermh, maybe I was remembering it wrong.
Comment #20
webchickCommitted and pushed to 8.x. Thanks!