Based on #1498634: [meta] Define revision/translation SQL schema for core entities (no patch) there should be a new schema: before beta we need to add support for the data table so content blocks become fully translatable.

CommentFileSizeAuthor
#19 block_content-ml_schema-2312153-13.patch10.22 KBplach
#15 block_content-ml_schema-2312153-13-fail.patch10.14 KBplach
#13 block_content-ml_schema-2312153-13.patch10.22 KBplach
#13 block_content-ml_schema-2312153-13.interdiff.txt1.37 KBplach
#13 block_content-ml_schema-2312153-13-fail.patch10.14 KBplach
#7 block_content-ml_schema-2312153-7.patch9.17 KBplach
#7 block_content-ml_schema-2312153-7.interdiff.txt609 bytesplach
#6 block_content-ml_schema-2312153-6.patch9.09 KBplach
#6 block_content-ml_schema-2312153-6.interdiff.txt3.2 KBplach
#4 block_content-ml_schema-2312153-4.patch5.9 KBplach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Issue tags: +sprint

Tagging for sprint to get more eyes on this.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Parent issue: #1498664: Refactor user entity properties to multilingual »
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Issue summary: View changes
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Active » Needs review
FileSize
block_content-ml_schema-2312153-4.patch5.9 KB

First patch, let's see how many failures we have.

Status: Needs review » Needs work

The last submitted patch, 4: block_content-ml_schema-2312153-4.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs work » Needs review
FileSize
block_content-ml_schema-2312153-6.interdiff.txt3.2 KB
block_content-ml_schema-2312153-6.patch9.09 KB

This should fix test failures. We should be ready to go.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
FileSize
block_content-ml_schema-2312153-7.interdiff.txt609 bytes
block_content-ml_schema-2312153-7.patch9.17 KB

Forgot one commit

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

The latest interdiff seems needs test, it's not clear why block description should be unique.
Otherwise RTBC +1

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented

Yep, I'll add some test coverage later.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Priority: Normal » Critical

Wow, looks very nice. I think needs to be bumped to critical due to huge changes to the underlying schema, even though it will result in less code and more standard behaviour :)

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: +Needs tests

Looks like only needs tests then?

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented

It's just a minor test addition for #7, it should be easy.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Priority: Critical » Normal
FileSize
block_content-ml_schema-2312153-13-fail.patch10.14 KB
block_content-ml_schema-2312153-13.interdiff.txt1.37 KB
block_content-ml_schema-2312153-13.patch10.22 KB

Here it is

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Priority: Normal » Critical
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
FileSize
block_content-ml_schema-2312153-13-fail.patch10.14 KB

Re-uploading the fail one...

Status: Needs review » Needs work

The last submitted patch, 15: block_content-ml_schema-2312153-13-fail.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs work » Reviewed & tested by the community

Great!

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented

Thanks, patch to commit is in #13.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
FileSize
block_content-ml_schema-2312153-13.patch10.22 KB

Re-uploading RTBC one, just in case...

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 4338c8b and pushed to 8.x. Thanks!

  • alexpott committed 4338c8b on 8.0.x 
    Issue #2312153 by plach: Refactor block_content entity schema to...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: -sprint

Yay, thanks!

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Issue tags: -beta-deadline +beta deadline
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Priority: Critical » Major

For metrics purposes this would not have been a release blocker. :) Major though for sure.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.