Remove the format_interval function after #2149197: Replace format_interval with \Drupal::service('date')->formatInterval() is committed.

CommentFileSizeAuthor
#2 drupal8-remove-format-interval-2308783.patch1.08 KBer.pushpinderrana
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikey_p’s picture

mikey_p CreditAttribution: mikey_p commented
Parent issue: » #2205673: [META] Remove all @deprecated functions marked "remove before 8.0"
er.pushpinderrana’s picture

er.pushpinderrana CreditAttribution: er.pushpinderrana commented
Status: Active » Needs review
Issue tags: +deprecated
FileSize
drupal8-remove-format-interval-2308783.patch1.08 KB

As #2149197: Replace format_interval with \Drupal::service('date')->formatInterval() issue fixed, ready to remove this. Please review updated patch.

mikey_p’s picture

mikey_p CreditAttribution: mikey_p commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work

Can we add this issue to the relevant CR - also #2149197: Replace format_interval with \Drupal::service('date')->formatInterval() should be added to.

mikey_p’s picture

mikey_p CreditAttribution: mikey_p commented
Status: Needs work » Needs review

Links added, should I create a separate CR for the removal of format_interval?

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

nope, updating the existing is enough

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 6948f38 and pushed to 8.x. Thanks!

  • alexpott committed 6948f38 on 8.0.x 
    Issue #2308783 by er.pushpinderrana | mikey_p: Remove format_interval().

Status: Fixed » Needs work

The last submitted patch, 2: drupal8-remove-format-interval-2308783.patch, failed testing.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Needs work » Fixed

Silly testbot

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.