Meta issue: #2205673: [meta] Remove all @deprecated functions marked "remove before 8.0"

Only the function exists, the usage of the function is already removed.

[ashish@xeon:~/proj/self/d8/data/drupal8]$grep views_get_plugin_definitions -r *
core/modules/views/views.module:function views_get_plugin_definitions() {
[ashish@xeon:~/proj/self/d8/data/drupal8]$

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

a_thakur’s picture

Status: Active » Needs review
FileSize
711 bytes

Please find the attached patch.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Nice!

KarlKedrovsky’s picture

I looked at the patch and ensured that all of the comments and code for this function were removed and that no other lines were added or removed.

Did a find/grep on the D8 code base to ensure that no other mentions of this function exist.

Checked to ensure that the patch still applies cleanly.

Looks goo to me!

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Can we add this issue to relevant change record. Thanks.

alexpott’s picture

Issue tags: +Needs reroll

Actually there will not be a change record - the process is to write one against views.

This patch now needs a reroll.

amitgoyal’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
699 bytes

Re-rolled.

leeotzu’s picture

Status: Needs review » Reviewed & tested by the community

Did a grep on the D8 code base after applying the rerolled patch. No trace of function views_get_plugin_definitions found in the code base.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 2a806cc and pushed to 8.x. Thanks!

  • alexpott committed 2a806cc on 8.0.x
    Issue #2306471 by amitgoyal, a_thakur: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

a_thakur’s picture

a_thakur’s picture

Issue summary: View changes
a_thakur’s picture

Please ignore. Accidentally edited the summary.