CommentFileSizeAuthor
#1 interdiff.txt2.97 KBslashrsm
#1 2305649_1.patch4.12 KBslashrsm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

slashrsm’s picture

Status: Active » Needs review
FileSize
4.12 KB
2.97 KB

Interdiff is against #2297915-8: Various fixes: PSR-4, correctly set expiration time, tests. Patch includes two things: fix $expire argument handling in set to follow what PHPdoc says about CacheBackendInterface::set() and cache all items permanently and handle expiration in backend's logic.

damiankloip’s picture

Status: Needs review » Fixed

Let's get this in now, as it works, and simplifies things. Which is always good for now :) Get things working, then extend it further.

Me and catch are considering TTL support still, but we can add that back in easily. Also we may end up setting an expiration time for the memcache item. Both can be discussed and done separately though.

Thanks.

  • damiankloip committed fa8163b on 8.x-2.x
    Issue #2305649 by slashrsm, damiankloip: Fix/update expiration logic.
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.