Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Loosely based on walkah's idea I have changed a bit file_check_location. Most of the problems related to file_check_upload is gone now but still we have one: the system temporary directory. Please really look at the patch and let's decide whether file_check_upload is really necessary for $directory_temp or not.
Comment | File | Size | Author |
---|---|---|---|
file_check_location.patch | 2.34 KB | chx | |
Comments
Comment #1
walkah CreditAttribution: walkah commented+1 - we obviously need it and I think the approach is sane- it also seems to work in my testing.
one thing - with this approach, though, is that chx's modifications mean that files that /don't/ exist are gonna end up looking like : files//etc/passwd (for example) when they come out of file_create_path(). I, personally, don't see much issue in that..
Comment #2
Dries CreditAttribution: Dries commentedCommitted it to HEAD and DRUPAL-4-6 so we can test it.
Comment #3
ec CreditAttribution: ec commentedDo this patch also close this issue http://drupal.org/node/10885 ? regards, eric.
Comment #4
(not verified) CreditAttribution: commented