Remove drupal_retrieve_form() as it is deprecated as per meta https://www.drupal.org/node/2205673.

submitted the patch for same.

CommentFileSizeAuthor
#2 remove-drupal-retrieve-form-2301593-2.patch776 byteser.pushpinderrana
remove-drupal-retrieve-form.patch740 bytesjoshi.rohit100
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Needs review » Needs work
Issue tags: -undefined +@deprecated, +Needs reroll

There are no usages, but the patch does not apply anymore.

er.pushpinderrana’s picture

er.pushpinderrana CreditAttribution: er.pushpinderrana commented
Status: Needs work » Needs review
FileSize
remove-drupal-retrieve-form-2301593-2.patch776 bytes

Rerolled patch.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

Nice, thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work

Can we add this issue to the relevant change record?

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented

Isn't https://www.drupal.org/node/2121003 enough? I couldn't find of any other.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Needs work » Reviewed & tested by the community

Ah, understood. Edited the change record for referencing this issue too.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed fef9fd2 and pushed to 8.0.x. Thanks!

  • alexpott committed fef9fd2 on 8.0.x 
    Issue #2301593 by er.pushpinderrana, joshi.rohit100: Remove...

Status: Fixed » Needs work

The last submitted patch, 2: remove-drupal-retrieve-form-2301593-2.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.