When the File entity got moved to use Drupal\file\Entity\File some typehints where not updated - lets take the opportunity to typehint on the interface.

CommentFileSizeAuthor
#3 2301493.3.patch17.43 KBalexpott
#3 1-3-interdiff.txt4.12 KBalexpott
#1 2301493.1.patch12.89 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Active » Needs review
FileSize
2301493.1.patch12.89 KB

Status: Needs review » Needs work

The last submitted patch, 1: 2301493.1.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Needs work » Needs review
FileSize
1-3-interdiff.txt4.12 KB
2301493.3.patch17.43 KB

Forgot to update the implementation of FileUsageInterface.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community

Looks fine :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Nice catch.

Committed and pushed to 8.x. Thanks!

  • webchick committed c9b2ff5 on 8.x 
    Issue #2301493 by alexpott: Fixed Typehint Drupal\file\File is does not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.