Remove path_is_admin() as it is deprecated

#2300809: Remove all usage of path_is_admin() as it is deprecated should be merged here

Merged! Please review attached patch.

Patch looks good, but i realized there is no change record for that yet

Needs work per #3.

+++ b/core/includes/common.inc
@@ -1735,7 +1735,6 @@ function _drupal_add_js($data = NULL, $options = NULL) {
-          // The function path_is_admin() is not available on update.php pages.
           if (!(defined('MAINTENANCE_MODE'))) {
             $current_path_is_admin = \Drupal::service('router.admin_context')->isAdminRoute();
           }

Well, technically it is available now, it should just return FALSE

+++ b/core/includes/common.inc
@@ -1744,9 +1744,8 @@ function _drupal_add_js($data = NULL, $options = NULL) {
-            $current_path_is_admin = \Drupal::service('router.admin_context')->isAdminRoute();
+            $current_path_is_admin = FALSE;

Oh, well I meant that we should just call the method.

Like this?

yeah

Still need a CR

I've expanded https://www.drupal.org/node/2224207

Yeah I do like this, ... made the code a bit more verbose/concrete.

It's good to show where to get $route from, but as someone who hasn't had much to do with D8 routing I don't really understand the routeMatch line. Is that just getting the route for the current request? If so, why not just leave out the $route parameter? What is the equivalent of passing an arbitrary $path string?

reroll

Patch still applies, CR is done, and there are no other occurrences of path_is_admin() with the patch applied. RTBC.

+++ b/core/includes/common.inc
@@ -1475,11 +1475,7 @@ function _drupal_add_js($data = NULL, $options = NULL) {
-          $current_path_is_admin = FALSE;
-          // The function path_is_admin() is not available on update.php pages.
-          if (!(defined('MAINTENANCE_MODE'))) {
-            $current_path_is_admin = \Drupal::service('router.admin_context')->isAdminRoute();
-          }
+          $current_path_is_admin = \Drupal::service('router.admin_context')->isAdminRoute();

So much nicer! :)

Ooh, no longer applies now that #2362227: Replace all instances of current_path() has landed. Rerolled.

RBTC again.

Searching change records for "path_is_admin" returns the change record in the results, so we look good to go there. I wasn't able to find any other instances after applying the patch. This type of change is explicitly allowed, per https://www.drupal.org/contribute/core/beta-changes.

Committed and pushed to 8.0.x. Thanks!