I love how geniously simple this module integrates twig into drupal 7. I've found 2 problems though. The first, is the name. Unless you are swedish and listen to the Curly Cast I doubt anybody will find this module. Or maybe that is intentional? If so, well done. :) To make it easier to find for people wanting to use twig in D7 it could use the word twig in the title.. :)

The other problem I have found is performance. I migrated a view with 10 rows that were outputted using Display Suite view mode for every row and did some unscientific benchmarks( I did the render a couple of times and checked the view render time. Here are the results:

With Display Suite: ~1700ms
With slate: ~13700ms

CommentFileSizeAuthor
#1 2293883-1-cache-drupal_system_listing.patch798 bytesemattias

Comments

emattias’s picture

emattias commented
StatusFileSize
new 2293883-1-cache-drupal_system_listing.patch798 bytes

Here's a patch that caches drupal_system_listing().

With this patch the same view renders in: ~280ms!

emattias’s picture

emattias commented
Title: Scans way more than necessary » Runs drupal_system_listing() way more than needed
emattias’s picture

emattias commented
Status: Active » Needs review

  • logaritmisk committed b190eef on 7.x-2.x authored by emattias 
    Issue #2293883 by emattias: Runs drupal_system_listing() way more than...
logaritmisk’s picture

logaritmisk commented
Status: Needs review » Closed (fixed)

I like the speed up! I've committed your patch and created a new alpha release. Thanks!