In forum module, In Overview form, still using $this->urlGenerator()->generateFromPath() as it is deprecated.

So it should be $this->url().

Submitted patch for the same.

CommentFileSizeAuthor
forum-overview-url.patch917 bytesjoshi.rohit100
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

Status: Needs review » Reviewed & tested by the community

Thanks

Status: Reviewed & tested by the community » Needs work

The last submitted patch, forum-overview-url.patch, failed testing.

joshi.rohit100’s picture

Status: Needs work » Needs review

forum-overview-url.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, forum-overview-url.patch, failed testing.

joshi.rohit100’s picture

I am bit amazed, when I created this patch, Oveview.php was using url() method and patch was RTBC at that time. But now what I am seeing is that it is already implemented in Overview.php as was in patch. Don't know whats this. somebody help me here.

LinL’s picture

@joshi.rohit100, it looks like it was committed a couple of days ago:

http://cgit.drupalcode.org/drupal/log/core/modules/forum/src/Form/Overvi...

but not marked as such here.

Not sure what to do... It doesn't seem right to close this issue as fixed. Maybe change the status here to RTBC again so that it can be finished off??

joshi.rohit100’s picture

Status: Needs work » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

@webchick a36a116 and pushed to 8.x already :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.