OpmlFeedAdd form in aggregator module is still using the D7 version url() method.
It should use \Drupal::url() as per D8 standard.

Attached the patch for the same.

CommentFileSizeAuthor
#2 interdiff-opmlfeedform-use-drupalurl-not-url.txt816 bytesjoshi.rohit100
#2 opmlfeedform-use-drupalurl-not-url-2.patch908 bytesjoshi.rohit100
opmlfeedform-use-drupalurl-not-url.patch910 bytesjoshi.rohit100
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Isn't $this->url available?

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented
FileSize
opmlfeedform-use-drupalurl-not-url-2.patch908 bytes
interdiff-opmlfeedform-use-drupalurl-not-url.txt816 bytes

Yes , you are right. we can use the $this->url().
There is also another way :- $this->urlGenerator()->generate().

But I think, $this->url() is better and simple.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Cool, thanks.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed daeb8b4 and pushed to 8.x. Thanks!

  • alexpott committed daeb8b4 on 8.x 
    Issue #2293643 by joshi.rohit100: Fixed OpmlFeedAdd form still using url...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.