Remove drupal_get_token and drupal_valid_token.

Meta Issue.
#1916134: Remove module_* deprecated functions

CommentFileSizeAuthor
#5 issue-2293541-5.patch8.82 KBamitgoyal
#1 issue-2293541.patch8.79 KBmarcingy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Status: Active » Needs review
FileSize
issue-2293541.patch8.79 KB

This just does the change and the removal in one, the function is deprecated and we have very few usages of each function so lets just get it removed.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Status: Needs review » Reviewed & tested by the community

Looks good.

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Issue tags: +@deprecated
Parent issue: » #2205673: [META] Remove all @deprecated functions marked "remove before 8.0"

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: issue-2293541.patch, failed testing.

amitgoyal’s picture

amitgoyal CreditAttribution: amitgoyal commented
Status: Needs work » Needs review
FileSize
issue-2293541-5.patch8.82 KB

Patch in #1 no longer applies. Please review updated patch.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 1cf3a53 and pushed to 8.x. Thanks!

  • alexpott committed 1cf3a53 on 8.x 
    Issue #2293541 by amitgoyal, marcingy: Remove *_token deprecated...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.