The StringTranslationTrait trait doxygen could use a little love

Re-roll of #1.

This is great documentation -- very clear and explains why I would want to use this.

A few little things to fix:

a) Not only t() but formatPlural() is added, and using both methods is essential for making sure text is translatable.

b) translateable is misspelled (should be translatable).

c)

+ * every translateable string similarly to how procedural code must use the

How about "... every translatable string, similar to how..." ?

d) Maybe add

@see container

at the end to link to the Services and Container topic (since you talk about injecting services)?

e)

+ * @see Drupal\Core\StringTranslation\TranslationInterface

Class namespace should start with \

Incorporated all #5 suggested points in this patch. Please review.

Thanks! Almost there...

 * Using this trait will add a t() and formatPlural() method to the class. This must be used for

Should say "add t() and formatPlural() methods" and "These must be used", since there are now two methods described. And then in the next sentence:

+ * every translatable string, similar to how procedural code must use the
+ * global function t(). This allows string extractor tools to find

... global functions t() and formatPlural().

Also that first line is too long. Documentation lines should not exceed 80 characters.

@jhodgdon, please review, did the required changes.

99% there, thanks!

+ * must use the global function t() and formatPlural(). This allows string

function -> functions

Changed function to functions.

Looks good now, thanks!

+++ b/core/lib/Drupal/Core/StringTranslation/StringTranslationTrait.php
@@ -10,14 +10,17 @@
+ * must be used for every translatable string, similar to how procedural code
+ * must use the global functions t() and formatPlural(). This allows string

format_plural() - we're talking about the procedural function here.

I've reverted 4b91f16d48490343f0d0c5abf1b915b21788550c so that we can get the correct commit history. Patch in #13 is the correct patch to review :)

Looking at the patch in #13:

+ * Using this trait will add t() and format_plural() methods to the class.

No, I think the methods added are t() and formatPlural(), right?

and then:

+ * These must be used for every translatable string, similar to how procedural
+ * code must use the global functions t() and formatPlural(). This allows

this should say global functions t() and format_plural().

Thanks LinL! This patch looks right to me.

Committed aa898f8 and pushed to 8.x. Thanks!