Standardize taxonomy term entity route names

Canonical currently is -

*   links = {
 *     "canonical" = "taxonomy.term_page",

The common format is: $entityname.$relationship, where $entityname is the machine name of the entity and $relationship is the relationship as defined in the entity annotation, machine-name-ified. (Convert - to _). The one exception is "canonical", which should be named "page" in the route.

I don't think canonical needs to be change unless I am missing something.

Suppose proper approach.

Vocabulary 'add-form' link was broken, and added to Term new one

PS: no interdiff, because previous patch was mostly wrong

+++ b/core/modules/taxonomy/src/Entity/Term.php
@@ -43,10 +43,11 @@
+ *     "admin-form" = "entity.taxonomy_term.admin_form",

+++ b/core/modules/taxonomy/src/Entity/Vocabulary.php
@@ -35,11 +35,11 @@
+ *     "overview-form" = "entity.taxonomy_term.admin_form",

Here the admin form for terms is overview, imo that's fine

add-form for Term needs vocabulary, so taxonomy_term_page() can't use the route

last place, reformatted code

I guess that means it needs work.

makes sense, this route is bound to vocabulary

otoh this route could be named entity.taxonomy_vocabulary.canonical

+++ b/core/modules/system/src/Tests/Menu/BreadcrumbTest.php
@@ -245,7 +245,11 @@ function testBreadCrumbs() {
-      $menu_links = entity_load_multiple_by_properties('menu_link_content', array('title' => $edit['title[0][value]'], 'route_name' => 'taxonomy.term_page', 'route_parameters' => serialize(array('taxonomy_term' => $term->id()))));
+      $menu_links = entity_load_multiple_by_properties('menu_link_content', array(
+        'title' => $edit['title[0][value]'],
+        'route_name' => 'entity.taxonomy_term.canonical',
+        'route_parameters' => serialize(array('taxonomy_term' => $term->id())),
+      ));

-1 for those changes, it is just much harder to review with --color-words!! Well, it already happened

+++ b/core/modules/taxonomy/src/Entity/Term.php
@@ -43,10 +43,10 @@
  *   links = {
...
+ *     "admin-form" = "entity.taxonomy_vocabulary.overview_form",

As we you said, in this case this method should be moved to the Vocabulary which then though conflicts with the field_ui local tasks

#25.2 - this would be moved to own annotation key in #2309187: Fix double-link-entry between Entity and Entity Type classes

Okay, but please don't do that wrapping the future, if it is avoidable.

re-roll

re-rtbc

1. What are we doing with vocabulary's reset link?

   +++ b/core/modules/taxonomy/src/Entity/Vocabulary.php
   @@ -35,11 +35,11 @@
   - *     "add-form" = "taxonomy.term_add",
   - *     "delete-form" = "taxonomy.vocabulary_delete",
   + *     "add-form" = "entity.taxonomy_vocabulary.add_form",
   + *     "delete-form" = "entity.taxonomy_vocabulary.delete_form",
     *     "reset" = "taxonomy.vocabulary_reset",
   - *     "overview-form" = "taxonomy.overview_terms",
   - *     "edit-form" = "taxonomy.vocabulary_edit"
   + *     "overview-form" = "entity.taxonomy_vocabulary.overview_form",
   + *     "edit-form" = "entity.taxonomy_vocabulary.edit_form"
   

   The only link we're not changing is reset and there is no mention of why anywhere in the issue.

2. +++ b/core/modules/taxonomy/src/Entity/Vocabulary.php
   @@ -35,11 +35,11 @@
   - *     "add-form" = "taxonomy.term_add",
   ...
   + *     "add-form" = "entity.taxonomy_vocabulary.add_form",
   

   This is not the same thing at all. This has broken the operations on VocabularyListBuilder since with this patch add terms now goes to the add vocabulary page :)

3. +++ b/core/modules/taxonomy/taxonomy.links.action.yml
   @@ -1,11 +1,11 @@
    taxonomy_add_vocabulary_local_action:
   -  route_name: taxonomy.vocabulary_add
   +  route_name: entity.taxonomy_vocabulary.add_form
   ...
    taxonomy.term_add:
   -  route_name: taxonomy.term_add
   +  route_name: entity.taxonomy_term.add_form
   

   Let's make the action link names match.

4. +++ b/core/modules/taxonomy/taxonomy.links.contextual.yml
   @@ -1,17 +1,17 @@
    taxonomy.term_edit:
   ...
   -  route_name: taxonomy.term_edit
   +  route_name: entity.taxonomy_term.edit_form
   ...
    taxonomy.term_delete:
   ...
   -  route_name: taxonomy.term_delete
   +  route_name: entity.taxonomy_term.delete_form
   ...
    taxonomy.vocabulary_delete:
   ...
   -  route_name: taxonomy.vocabulary_delete
   +  route_name: entity.taxonomy_vocabulary.delete_form
   

   Let's make the contextual link names match the route.

1) Converted to "reset-form" for consistency with other forms, also added test to ensure that after reset user is back to overview form
2) reverted, missed this... when we back to link templates it would be a bit clear then term route lives in vocabulary
3) fixed
4) fixed

I wanted to RTBC this, but does not apply anymore.

+++ b/core/modules/taxonomy/src/Entity/Term.php
@@ -43,11 +43,11 @@
- *   field_ui_base_route = "taxonomy.overview_terms",
+ *   field_ui_base_route = "entity.taxonomy_term.admin_form",

+++ b/core/modules/taxonomy/src/Entity/Vocabulary.php
@@ -35,11 +35,11 @@
- *     "overview-form" = "taxonomy.overview_terms",
...
+ *     "overview-form" = "entity.taxonomy_term.admin_form",

still questional

Suppose this name fits better

Committed 92ff387 and pushed to 8.0.x. Thanks!