Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
When enabled, at each node view the forum module will attempt a vocabulary_load()
even when not necessary.
This can be avoided by moving 2 lines of code inside a if. Easy win. If we don't, we'll have the taxonomy term load operation attempted on every page that renders at least one node, even when no forum nodes at all are being manipulated.
Comment | File | Size | Author |
---|---|---|---|
#1 | 2291081-1-forum_node_view_useless_taxonomy_load.patch | 756 bytes | pounard |
Comments
Comment #1
pounardHere is the patch.
Comment #2
larowlanComment #5
pounardGood to go !
Comment #7
pounardI don't even understand why this patch fails one time out of two...
Comment #9
dcam CreditAttribution: dcam commentedHuh... good catch. RTBC +1 from me.
Don't worry about the test failure. It's a fatal error in an unrelated system, indicating the testing client just crashed or something. 7.x patches that are RTBC are constantly having these issues. I have about 24 others in my queue and I have to do upkeep on some of them every day to put them back at RTBC. If it happens again just retest the patch so it will be green and set it back to RTBC.
Comment #10
pounardThanks, still good to go then.
Comment #13
dcam CreditAttribution: dcam commentedComment #16
dcam CreditAttribution: dcam commentedComment #19
dcam CreditAttribution: dcam commentedComment #22
dcam CreditAttribution: dcam commentedComment #25
dcam CreditAttribution: dcam commentedComment #28
dcam CreditAttribution: dcam commentedComment #31
dcam CreditAttribution: dcam commentedComment #34
dcam CreditAttribution: dcam commentedComment #37
dcam CreditAttribution: dcam commentedComment #40
dcam CreditAttribution: dcam commentedComment #43
dcam CreditAttribution: dcam commentedComment #44
David_Rothstein CreditAttribution: David_Rothstein commentedCommitted to 7.x - thanks!
Comment #46
pounardThanks !