Problem/Motivation

In views RSS plugins and elsewhere we use the config name 'item_length' to denote the view mode that the item is rendered in in the RSS feed. It once was 'item length' in 4.7, ie the trim length. It no longer is item length, its a view mode.

Proposed resolution

Rename it to aid discoverability/understanding

Remaining tasks

Patch
Reviews

User interface changes

None

API changes

Config schema changes, form field name changes

CommentFileSizeAuthor
#4 2290103-4.patch9.91 KBdamiankloip
#1 item_length_rename.1.patch10.43 KBlarowlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Active » Needs review
FileSize
item_length_rename.1.patch10.43 KB

<3 grep + sed (the gnu flavours, not the OSX pov ones)

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Issue tags: +VDC

tagging.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Component: views.module » other

Looks fine to me.

+++ b/core/modules/system/tests/upgrade/drupal-7.system.database.php
@@ -72,7 +72,7 @@
+    'name' => 'feed_view_mode',

I'm not sure making the name change in this file too is correct?

Moving to 'other' as this is not just a views thing. VDC tag should be ok here?

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
FileSize
2290103-4.patch9.91 KB

Rerolled for view_mode change in #2289095: "Frontpage" view, feed display renders the node comment form:

+++ b/core/modules/node/config/install/views.view.frontpage.yml
@@ -229,7 +229,7 @@ display:
-          item_length: rss
+          view_mode: rss

Also removed changes from drupal-7.system.database.php

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Just in case someone wondered, historic reasons: rss did not supported view modes at some point so using item_length allowed us to be able to not break existing views while supporting both features at the same time.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 7332211 and pushed to 8.x. Thanks!

  • alexpott committed 7332211 on 8.x 
    Issue #2290103 by damiankloip, larowlan: Rename 'item_length' to '...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.