It's great that this module supports the core toolbar and admin_menu out of the box, but we should consider backporting what the D8 version of the module does to support use of the https://drupal.org/project/navbar module when used in Drupal 7.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Issue summary: View changes
Dave Reid’s picture

Status: Active » Needs review
FileSize
5.31 KB

Here's a diff against a fairly recent 7.x-2.x-dev build, so I hope it still applies to the branch. This seems to get me what I need. I couldn't use the same pattern that Drupal.behaviors.environment_indicatorAdminMenu does by defining Drupal.admin.behaviors['environment_indicator'] because the navbar.js file that contains Drupal.behaviors.navbar runs before the environment indicator behaviors on my site.

Dave Reid’s picture

Revised version floats the environment indicator off to the left side. Screenshot attached of it in use with a fairly narrow viewport and the Ember theme:

Dave Reid’s picture

Needed one little merge conflict fixed to truly apply to the latest 7.x-2.x branch.

  • Commit 1698d57 on 7.x-2.x authored by Dave Reid, committed by e0ipso:
    Issue #2287983 by davereid: Add navbar support.
    
  • Commit 4d838cc on 7.x-2.x by e0ipso:
    Issue #2287983 by e0ipso: Prettify navbar integration.
    
e0ipso’s picture

Status: Needs review » Fixed
Dave Reid’s picture

FileSize
7.09 KB
7 KB

Awesome! Thanks for helping bring it home and getting it in. It does look like we could have a follow-up for the styling of the 'Available environments'. This is what I'm seeing compared to the other navbar 'sub-bars': it's really thin and doesn't appear to have the same styling.

e0ipso’s picture

Status: Fixed » Needs work

I see what's going on… I'll do a follow up.

  • Commit a63d9ef on 7.x-2.x by e0ipso:
    Issue #2287983 by e0ipso: Missing class for empty environments.
    
Dave Reid’s picture

Status: Needs work » Fixed

Ok great. I thought maybe it might be worth a discussion about either removing the tab bar altogether if there aren't any other environments, or maybe a link to the settings page to create new environments, but as per the original request this is resolved. Thanks so much @e0ipso!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.