This patch makes the task info more readable

CommentFileSizeAuthor
#8 eldir-2283159-hosting-task-info.patch4.09 KBsteven jones
#4 eldir-2283159-task-info-width.patch602 bytessteven jones
#1 eldir-view_task_modal_css_styles-2283159-1.patch1.06 KBarosboro
eldir-view_task_modal_css_styles.patch1.07 KBarosboro

Comments

arosboro’s picture

arosboro commented
StatusFileSize
new eldir-view_task_modal_css_styles-2283159-1.patch1.06 KB

Fix some stuff that was broken with the width of the task info and other info panes that were affected by the same styles.

arosboro’s picture

arosboro commented
Status: Needs review » Needs work

The issue is that there is no way to tell whether a task has just been created. This message needs position relative for the label when there is a lot of text to the right, but all other labels should be absolute with a 100px padding to align the contents in a column.

steven jones’s picture

steven jones commented

Let's split this issue into 2 parts:

  1. Get the task info box to be full-width
  2. Change the info box to be a proper table or definition list.
steven jones’s picture

steven jones commented
StatusFileSize
new eldir-2283159-task-info-width.patch602 bytes

Here's a patch for part 1.

  • Steven Jones committed 7af76de on 7.x-3.x 
    Issue #2283159 by arosboro, Steven Jones: Increase task information info...
steven jones’s picture

steven jones commented

Pushed that change to Eldir 3.x.

Now to work on point 2.

steven jones’s picture

steven jones commented

I think that this looks like something that comes along and re-formats the '#type' => 'item' into a table for rendering.

steven jones’s picture

steven jones commented
StatusFileSize
new eldir-2283159-hosting-task-info.patch4.09 KB

Here's a work in progress, there's essentially a compatibility layer added and eldir uses a pre render to move the items into a slightly different structure that is then worked on by a new theme rendering function.

The idea would be to test this out in Eldir get it working and then move the theme function and compatibility layer into hosting proper, then the CSS stays in Eldir.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented

+1. The modal stuff in Aegir 3 is kinda janky.

  • Steven Jones committed db8a93d6 on 7.x-3.x 
    Issue #2283159 by Steven Jones: Improve tasks modal styles for...
steven jones’s picture

steven jones commented
Status: Needs work » Fixed

Decided to go for it, and committed the fix in #8 with a little extra bit for servers.

  • Steven Jones committed c1c775db on 7.x-3.x 
    Issue #2283159 by Steven Jones: Stop fiddling with the weights.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.